From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by ml01.01.org (Postfix) with ESMTP id DC58F212FD4E4 for ; Wed, 31 Jul 2019 18:39:43 -0700 (PDT) Subject: Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax. References: <20190731114935.11030-1-ruansy.fnst@cn.fujitsu.com> <20190731203324.7vjwlejmwpghpvqi@fiona> From: Shiyang Ruan Message-ID: <800ff77a-7cd1-5fa1-fcf7-e41264a3f189@cn.fujitsu.com> Date: Thu, 1 Aug 2019 09:37:04 +0800 MIME-Version: 1.0 In-Reply-To: <20190731203324.7vjwlejmwpghpvqi@fiona> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Goldwyn Rodrigues Cc: qi.fuli@fujitsu.com, gujx@cn.fujitsu.com, darrick.wong@oracle.com, linux-nvdimm@lists.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org List-ID: On 8/1/19 4:33 AM, Goldwyn Rodrigues wrote: > On 19:49 31/07, Shiyang Ruan wrote: >> This patchset aims to take care of this issue to make reflink and dedupe >> work correctly in XFS. >> >> It is based on Goldwyn's patchsets: "v4 Btrfs dax support" and "Btrfs >> iomap". I picked up some patches related and made a few fix to make it >> basically works fine. >> >> For dax framework: >> 1. adapt to the latest change in iomap. >> >> For XFS: >> 1. report the source address and set IOMAP_COW type for those write >> operations that need COW. >> 2. update extent list at the end. >> 3. add file contents comparison function based on dax framework. >> 4. use xfs_break_layouts() to support dax. > > Shiyang, > > I think you used the older patches which does not contain the iomap changes > which would call iomap_begin() with two iomaps. I have it in the btrfs-iomap Oh, Sorry for my carelessness. This patchset is built on your "Btrfs iomap". I didn't point it out in cover letter. > branch and plan to update it today. It is built on v5.3-rcX, so it should > contain the changes which moves the iomap code to the different directory. > I will build the dax patches on top of that. > However, we are making a big dependency chain here Don't worry. It's fine for me. I'll follow your updates. > -- Thanks, Shiyang Ruan. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm