From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 2/5] libnvdimm/pfn: Prevent raw mode fallback if pfn-infoblock valid
Date: Mon, 02 Mar 2020 17:32:50 +0530 [thread overview]
Message-ID: <87imjnrml1.fsf@linux.ibm.com> (raw)
In-Reply-To: <158291747661.1609624.13504407869218712107.stgit@dwillia2-desk3.amr.corp.intel.com>
Dan Williams <dan.j.williams@intel.com> writes:
> The EOPNOTSUPP return code from the pmem driver indicates that the
> namespace has a configuration that may be valid, but the current kernel
> does not support it. Expand this to all of the nd_pfn_validate() error
> conditions after the infoblock has been verified as self consistent.
>
> This prevents exposing the namespace to I/O when the infoblock needs to
> be corrected, or the system needs to be put into a different
> configuration (like changing the page size on PowerPC).
>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/nvdimm/pfn_devs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c
> index a5c25cb87116..79fe02d6f657 100644
> --- a/drivers/nvdimm/pfn_devs.c
> +++ b/drivers/nvdimm/pfn_devs.c
> @@ -561,14 +561,14 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig)
> dev_dbg(&nd_pfn->dev, "align: %lx:%lx mode: %d:%d\n",
> nd_pfn->align, align, nd_pfn->mode,
> mode);
> - return -EINVAL;
> + return -EOPNOTSUPP;
> }
> }
>
> if (align > nvdimm_namespace_capacity(ndns)) {
> dev_err(&nd_pfn->dev, "alignment: %lx exceeds capacity %llx\n",
> align, nvdimm_namespace_capacity(ndns));
> - return -EINVAL;
> + return -EOPNOTSUPP;
> }
>
> /*
> @@ -581,7 +581,7 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig)
> if (offset >= resource_size(&nsio->res)) {
> dev_err(&nd_pfn->dev, "pfn array size exceeds capacity of %s\n",
> dev_name(&ndns->dev));
> - return -EBUSY;
> + return -EOPNOTSUPP;
> }
>
> if ((align && !IS_ALIGNED(nsio->res.start + offset + start_pad, align))
> @@ -589,7 +589,7 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig)
> dev_err(&nd_pfn->dev,
> "bad offset: %#llx dax disabled align: %#lx\n",
> offset, align);
> - return -ENXIO;
> + return -EOPNOTSUPP;
> }
>
> return 0;
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-03-02 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 19:17 [PATCH v3 0/5] libnvdimm: Cross-arch compatible namespace alignment Dan Williams
2020-02-28 19:17 ` [PATCH v3 1/5] mm/memremap_pages: Introduce memremap_compat_align() Dan Williams
2020-03-02 12:01 ` Aneesh Kumar K.V
2020-02-28 19:17 ` [PATCH v3 2/5] libnvdimm/pfn: Prevent raw mode fallback if pfn-infoblock valid Dan Williams
2020-03-02 12:02 ` Aneesh Kumar K.V [this message]
2020-02-28 19:18 ` [PATCH v3 3/5] libnvdimm/namespace: Enforce memremap_compat_align() Dan Williams
2020-03-02 12:08 ` Aneesh Kumar K.V
2020-03-02 18:45 ` Dan Williams
2020-02-28 19:18 ` [PATCH v3 4/5] libnvdimm/region: Introduce NDD_LABELING Dan Williams
2020-02-28 19:18 ` [PATCH v3 5/5] libnvdimm/region: Introduce an 'align' attribute Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imjnrml1.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).