From: Randy Dunlap <rdunlap@infradead.org>
To: Brendan Higgins <brendanhiggins@google.com>,
frowand.list@gmail.com, gregkh@linuxfoundation.org,
jpoimboe@redhat.com, keescook@google.com,
kieran.bingham@ideasonboard.com, mcgrof@kernel.org,
peterz@infradead.org, robh@kernel.org, sboyd@kernel.org,
shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com
Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com,
dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org,
khilman@baylibre.com, knut.omang@oracle.com, wfg@linux.intel.com,
joel@jms.id.au, rientjes@google.com, jdike@addtoit.com,
dan.carpenter@oracle.com, devicetree@vger.kernel.org,
linux-kbuild@vger.kernel.org, Tim.Bird@sony.com,
linux-um@lists.infradead.org, rostedt@goodmis.org,
julia.lawall@lip6.fr, kunit-dev@googlegroups.com, richard@nod.at,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
daniel@ffwll.ch, mpe@ellerman.id.au,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v17 07/19] kunit: test: add initial tests
Date: Sun, 22 Sep 2019 09:28:28 -0700 [thread overview]
Message-ID: <944ac47d-1411-9ebd-d0d4-a616c88c9c20@infradead.org> (raw)
In-Reply-To: <20190921001855.200947-8-brendanhiggins@google.com>
On 9/20/19 5:18 PM, Brendan Higgins wrote:
> Add a test for string stream along with a simpler example.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> ---
> lib/kunit/Kconfig | 25 ++++++++++
> lib/kunit/Makefile | 4 ++
> lib/kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++
> lib/kunit/string-stream-test.c | 52 ++++++++++++++++++++
> 4 files changed, 169 insertions(+)
> create mode 100644 lib/kunit/example-test.c
> create mode 100644 lib/kunit/string-stream-test.c
>
> diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig
> index 666b9cb67a74..3868c226cf31 100644
> --- a/lib/kunit/Kconfig
> +++ b/lib/kunit/Kconfig
> @@ -11,3 +11,28 @@ menuconfig KUNIT
> special hardware when using UML. Can also be used on most other
> architectures. For more information, please see
> Documentation/dev-tools/kunit/.
> +
> +if KUNIT
The 'if' above provides the dependency clause, so the 2 'depends on KUNIT'
below are not needed. They are redundant.
> +
> +config KUNIT_TEST
> + bool "KUnit test for KUnit"
> + depends on KUNIT
> + help
> + Enables the unit tests for the KUnit test framework. These tests test
> + the KUnit test framework itself; the tests are both written using
> + KUnit and test KUnit. This option should only be enabled for testing
> + purposes by developers interested in testing that KUnit works as
> + expected.
> +
> +config KUNIT_EXAMPLE_TEST
> + bool "Example test for KUnit"
> + depends on KUNIT
> + help
> + Enables an example unit test that illustrates some of the basic
> + features of KUnit. This test only exists to help new users understand
> + what KUnit is and how it is used. Please refer to the example test
> + itself, lib/kunit/example-test.c, for more information. This option
> + is intended for curious hackers who would like to understand how to
> + use KUnit for kernel development.
> +
> +endif # KUNIT
--
~Randy
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-09-22 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 0:18 [PATCH v17 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 01/19] kunit: test: add KUnit test runner core Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 02/19] kunit: test: add test resource management API Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 03/19] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 04/19] kunit: test: add assertion printing library Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 05/19] kunit: test: add the concept of expectations Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 06/19] lib: enable building KUnit in lib/ Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 07/19] kunit: test: add initial tests Brendan Higgins
2019-09-22 16:28 ` Randy Dunlap [this message]
2019-09-23 9:05 ` Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 08/19] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 09/19] kunit: test: add support for test abort Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 10/19] kunit: test: add tests for kunit " Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 11/19] kunit: test: add the concept of assertions Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 12/19] kunit: test: add tests for KUnit managed resources Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 13/19] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 14/19] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 15/19] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 16/19] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 17/19] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 18/19] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
2019-09-21 0:18 ` [PATCH v17 19/19] kunit: fix failure to build without printk Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=944ac47d-1411-9ebd-d0d4-a616c88c9c20@infradead.org \
--to=rdunlap@infradead.org \
--cc=Alexander.Levin@microsoft.com \
--cc=Tim.Bird@sony.com \
--cc=amir73il@gmail.com \
--cc=brendanhiggins@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=joel@jms.id.au \
--cc=jpoimboe@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@google.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-um@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wfg@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).