Re: [ndctl PATCH v2 2/2] libdaxctl: fix device reconfiguration with builtin drivers

[Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Wed, Sep 4, 2019 at 6:13 PM Vishal Verma <vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> When the driver of a given reconfiguration mode is builtin, libdaxctl
> isn't able to build a module lookup list using kmod. However, it doesn't
> need to fail in this case, as it is acceptable for a driver to be
> builtin.
>
> Indeed, since even with a modalias lookup list, we still have to resolve
> the target driver based on the mode using the module name, so relying on
> the modalias lookup to keep us impervious to module name changes is
> already flawed.
>
> Simplify module loading greatly by removing the modalias lookups, and
> directly getting the module from a named lookup. This transparently
> fixes the problem when the driver may be builtin instead of being a
> module.
>
> Link: https://github.com/pmem/ndctl/issues/108
> Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reported-by: Brice Goglin <Brice.Goglin-MZpvjPyXg2s@public.gmane.org>
> Reported-by: Dave Hansen <dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Vishal Verma <vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>
> v2:
>  - Remove modalias lookup lists entirely, and perform a simple name
>    based lookup (Dan)
>  - Fix the module expectation in the daxctl-devices unit test.
>
>  daxctl/lib/libdaxctl-private.h |  1 -
>  daxctl/lib/libdaxctl.c         | 75 ++++++++--------------------------
>  test/daxctl-devices.sh         |  7 +++-
>  3 files changed, 23 insertions(+), 60 deletions(-)

Mmm, that's nice.

Reviewed-by: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>