From: Dan Williams <dan.j.williams@intel.com>
To: Won-Kyo Choe <wkyo.choe@gmail.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [QUESTION] Error on initializing dax by using different struct page size
Date: Thu, 7 Nov 2019 07:54:21 -0800 [thread overview]
Message-ID: <CAPcyv4j-rSy-T5Qv6GbcDcmUerhQQYsMKbUY7EaGHz-GecKDtQ@mail.gmail.com> (raw)
In-Reply-To: <20191107152952.GA2053@swarm07>
On Thu, Nov 7, 2019 at 7:30 AM Won-Kyo Choe <wkyo.choe@gmail.com> wrote:
>
> Hi, there. I'm using Opatne DC memory to use it a volatile memory. Recently,
> I found that if sizeof(struct page) is above 64 bytes (e.g. 128 byes),
> `device_dax` cannot be initialized when system boots. I am aware that
> for some reason there is a function, `__mm_zero_struct_page`, which limits
> the size of struct page when it exceeds 80 bytes. However, due to the
> research purpose, I do not use that constraint and I'm quite certain
> that using different page size is usable in main memory. So, I'm
> wondering why this is not possible in persistent memory and which
> patches are related to this problem.
>
> I will attach the system log for clarification. The test is run in
> linux-5.3.9 and linuxt-5.3-rc5
How did you manage to build the kernel with a 128byte struct page
size? This build assert in drivers/nvdimm/pfn_devs.c
BUILD_BUG_ON(sizeof(struct page) > MAX_STRUCT_PAGE_SIZE);
...will start to trigger in v5.4 to explicitly prevent this going
forward. See commit e96f0bf2ec92 "libnvdimm/pfn_dev: Add a build check
to make sure we notice when struct page size change" for more details.
In general 64-bytes per page is already expensive 128 bytes is a
gigantic struct page.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-11-07 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 15:29 [QUESTION] Error on initializing dax by using different struct page size Won-Kyo Choe
2019-11-07 15:54 ` Dan Williams [this message]
2019-11-07 19:00 ` Won-Kyo Choe
2019-11-07 19:24 ` Dan Williams
2019-11-08 4:26 ` Won-Kyo Choe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4j-rSy-T5Qv6GbcDcmUerhQQYsMKbUY7EaGHz-GecKDtQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=wkyo.choe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).