From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"Tsaur, Erwin" <erwin.tsaur@intel.com>
Subject: Re: [ndctl PATCH] Expose ndctl_bus_nfit_translate_spa as a public function.
Date: Fri, 26 Feb 2021 21:41:45 +0000 [thread overview]
Message-ID: <d2df67801c1e0894e276f1792976ec66a00ba7a7.camel@intel.com> (raw)
In-Reply-To: <20210224234814.1021-1-erwin.tsaur@intel.com>
On Wed, 2021-02-24 at 15:48 -0800, Tsaur, Erwin wrote:
> The motivation is to allow access to ACPI defined NVDIMM Root Device _DSM Function Index 5(Translate SPA). The rest of the _DSM functions, which are mostly ARS related, are already public.
>
> Basically move ndctl_bus_nfit_translate_spa declaration from private.h to libndctl.h.
> ---
> ndctl/lib/libndctl.sym | 4 ++++
> ndctl/lib/nfit.c | 2 +-
> ndctl/lib/private.h | 2 --
> ndctl/libndctl.h | 2 ++
> 4 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/ndctl/lib/libndctl.sym b/ndctl/lib/libndctl.sym
> index 0a82616..58afb74 100644
> --- a/ndctl/lib/libndctl.sym
> +++ b/ndctl/lib/libndctl.sym
> @@ -451,3 +451,7 @@ LIBNDCTL_25 {
> ndctl_bus_clear_fw_activate_nosuspend;
> ndctl_bus_activate_firmware;
> } LIBNDCTL_24;
> +
> +LIBNDCTL_26 {
> + ndctl_bus_nfit_translate_spa;
> +} LIBNDCTL_25;
> diff --git a/ndctl/lib/nfit.c b/ndctl/lib/nfit.c
> index 6f68fcf..d85682f 100644
> --- a/ndctl/lib/nfit.c
> +++ b/ndctl/lib/nfit.c
> @@ -114,7 +114,7 @@ static int is_valid_spa(struct ndctl_bus *bus, unsigned long long spa)
> *
> * If success, returns zero, store dimm's @handle, and @dpa.
> */
> -int ndctl_bus_nfit_translate_spa(struct ndctl_bus *bus,
> +NDCTL_EXPORT int ndctl_bus_nfit_translate_spa(struct ndctl_bus *bus,
> unsigned long long address, unsigned int *handle, unsigned long long *dpa)
> {
>
>
>
>
> diff --git a/ndctl/lib/private.h b/ndctl/lib/private.h
> index ede1300..8f4510e 100644
> --- a/ndctl/lib/private.h
> +++ b/ndctl/lib/private.h
> @@ -370,8 +370,6 @@ static inline int check_kmod(struct kmod_ctx *kmod_ctx)
> return kmod_ctx ? 0 : -ENXIO;
> }
>
>
>
>
> -int ndctl_bus_nfit_translate_spa(struct ndctl_bus *bus, unsigned long long addr,
> - unsigned int *handle, unsigned long long *dpa);
> struct ndctl_cmd *ndctl_bus_cmd_new_err_inj(struct ndctl_bus *bus);
> struct ndctl_cmd *ndctl_bus_cmd_new_err_inj_clr(struct ndctl_bus *bus);
> struct ndctl_cmd *ndctl_bus_cmd_new_err_inj_stat(struct ndctl_bus *bus,
> diff --git a/ndctl/libndctl.h b/ndctl/libndctl.h
> index 60e1288..ee517a7 100644
> --- a/ndctl/libndctl.h
> +++ b/ndctl/libndctl.h
> @@ -237,6 +237,8 @@ unsigned long long ndctl_cmd_clear_error_get_cleared(
> struct ndctl_cmd *clear_err);
> unsigned int ndctl_cmd_ars_cap_get_clear_unit(struct ndctl_cmd *ars_cap);
> int ndctl_cmd_ars_stat_get_flag_overflow(struct ndctl_cmd *ars_stat);
> +int ndctl_bus_nfit_translate_spa(struct ndctl_bus *bus, unsigned long long addr,
> + unsigned int *handle, unsigned long long *dpa);
>
One nit here: can you group this with the other ndctl_bus_* function
declarations in this file?
Everything else looks good to me.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2021-02-26 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 23:48 [ndctl PATCH] Expose ndctl_bus_nfit_translate_spa as a public function Tsaur, Erwin
2021-02-26 19:20 ` Dan Williams
2021-02-26 21:41 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2df67801c1e0894e276f1792976ec66a00ba7a7.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=erwin.tsaur@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).