From: Andy Lutomirski <luto@kernel.org>
To: linux-nvme@lists.infradead.org
Cc: Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 4/4] Do not install /etc/nvme/hostid or /etc/nvme/hostnqn by default
Date: Thu, 19 Dec 2019 19:31:05 -0800 [thread overview]
Message-ID: <0537703137403a60ecd278610663db2d29f95624.1576726427.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1576726427.git.luto@kernel.org>
Pre-generating them is nonsensical for package managers. Moreover,
with the new systemd-generated ID support, it's preferable for the
files to be absent. Don't generate them unless explicitly requested.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index d88404dd51f6..acb6983cb5b1 100644
--- a/Makefile
+++ b/Makefile
@@ -140,14 +140,12 @@ install-hostparams: install-etc
install-etc:
$(INSTALL) -d $(DESTDIR)$(SYSCONFDIR)/nvme
- touch $(DESTDIR)$(SYSCONFDIR)/nvme/hostnqn
- touch $(DESTDIR)$(SYSCONFDIR)/nvme/hostid
if [ ! -f $(DESTDIR)$(SYSCONFDIR)/nvme/discovery.conf ]; then \
$(INSTALL) -m 644 -T ./etc/discovery.conf.in $(DESTDIR)$(SYSCONFDIR)/nvme/discovery.conf; \
fi
install-spec: install-bin install-man install-bash-completion install-zsh-completion install-etc install-systemd install-udev install-dracut
-install: install-spec install-hostparams
+install: install-spec
nvme.spec: nvme.spec.in NVME-VERSION-FILE
sed -e 's/@@VERSION@@/$(NVME_VERSION)/g' < $< > $@+
--
2.23.0
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-12-20 3:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 3:31 [PATCH 0/4] systemd ID improvements Andy Lutomirski
2019-12-20 3:31 ` [PATCH 1/4] hostnqn: Fix the systemd-based NQN namespace to comply with the spec Andy Lutomirski
2019-12-20 3:31 ` [PATCH 2/4] fabrics: Rename nvmf_hostnqn_file() to nvmf_hostnqn_load() Andy Lutomirski
2019-12-20 3:31 ` [PATCH 3/4] Use systemd-generated hostid if no hostid is configured Andy Lutomirski
2020-01-03 18:14 ` David Milburn
2020-01-13 19:14 ` Andy Lutomirski
2019-12-20 3:31 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0537703137403a60ecd278610663db2d29f95624.1576726427.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).