From: Sagi Grimberg <sagi@grimberg.me>
To: "Wunderlich, Mark" <mark.wunderlich@intel.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: Sighting: Kernel fault with large write (512k) and io_uring
Date: Mon, 23 Mar 2020 15:09:50 -0700 [thread overview]
Message-ID: <092f6922-ab29-c2bc-04b8-0d0c95c14ad6@grimberg.me> (raw)
In-Reply-To: <MW3PR11MB46844ED6C11993D7F5D911A8E5F00@MW3PR11MB4684.namprd11.prod.outlook.com>
>> Mark, does this patch make the issue go away?
>> --
>> @@ -2326,6 +2328,9 @@ static int nvme_tcp_poll(struct blk_mq_hw_ctx *hctx)
>> struct nvme_tcp_queue *queue = hctx->driver_data;
>> struct sock *sk = queue->sock->sk;
>>
>> + if (!test_bit(NVME_TCP_Q_LIVE, &queue->flags))
>> + return 0;
>> +
>> set_bit(NVME_TCP_Q_POLLING, &queue->flags);
>> if (sk_can_busy_loop(sk) && skb_queue_empty_lockless(&sk->sk_receive_queue))
>> sk_busy_loop(sk, true);
>
> Do not see the fault (on first attempt),
OK, this is a needed fix then.
> but as part of error recovery the initiator is not
> able to reconnect with target. Another separate issue?
Possibly,
>
> [ 304.395405] nvme nvme0: queue 5: timeout request 0x41 type 4
> [ 304.395407] nvme nvme0: starting error recovery
> [ 304.534399] nvme nvme0: Reconnecting in 10 seconds...
> [ 314.636262] nvme nvme0: Please enable CONFIG_NVME_MULTIPATH for full support of multi-port devices.
> [ 314.636323] nvme nvme0: creating 102 I/O queues.
> [ 378.117435] nvme nvme0: queue 5: timeout request 0x0 type 4
> [ 378.123398] nvme nvme0: Connect command failed, error wo/DNR bit: 881
> [ 378.123790] nvme nvme0: failed to connect queue: 5 ret=881
> [ 378.124338] nvme nvme0: Failed reconnect attempt 1
> [ 378.124339] nvme nvme0: Reconnecting in 10 seconds...
> [ 388.357615] nvme nvme0: Please enable CONFIG_NVME_MULTIPATH for full support of multi-port devices.
> [ 388.357670] nvme nvme0: creating 102 I/O queues.
> [ 451.848084] nvme nvme0: queue 5: timeout request 0x0 type 4
> [ 452.096044] nvme nvme0: Connect command failed, error wo/DNR bit: 881
> [ 452.096428] nvme nvme0: failed to connect queue: 5 ret=881
> [ 452.096762] nvme nvme0: Failed reconnect attempt 2
> [ 452.096763] nvme nvme0: Reconnecting in 10 seconds...
>
> And of coarse this does not explain why we have to initiate error recovery
> In the first place.
Yes, this is with nvme-5.7 tree right? which is currently based of
5.6.0-rc4 correct?
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-23 22:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 23:37 Sighting: Kernel fault with large write (512k) and io_uring Wunderlich, Mark
2020-03-19 1:12 ` Sagi Grimberg
2020-03-19 2:33 ` Jens Axboe
2020-03-23 21:07 ` Wunderlich, Mark
2020-03-23 21:11 ` Sagi Grimberg
2020-03-23 21:18 ` Sagi Grimberg
2020-03-23 22:04 ` Wunderlich, Mark
2020-03-23 22:09 ` Sagi Grimberg [this message]
2020-03-23 23:16 ` Wunderlich, Mark
2020-03-23 23:29 ` Sagi Grimberg
2020-03-23 23:45 ` Wunderlich, Mark
2020-03-23 23:48 ` Sagi Grimberg
2020-03-24 0:34 ` Wunderlich, Mark
2020-03-24 1:29 ` Sagi Grimberg
2020-03-24 16:31 ` Wunderlich, Mark
2020-03-24 19:13 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=092f6922-ab29-c2bc-04b8-0d0c95c14ad6@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=linux-nvme@lists.infradead.org \
--cc=mark.wunderlich@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).