From: Sagi Grimberg <sagi@grimberg.me>
To: Colin King <colin.king@canonical.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: fix uninitialized return of ret when sysfs_create_link fails
Date: Fri, 4 Oct 2019 17:02:29 -0700 [thread overview]
Message-ID: <17e3dc55-6e6e-a4e8-f082-4b57144467af@grimberg.me> (raw)
In-Reply-To: <20191002124328.17264-1-colin.king@canonical.com>
This was already fixed and merged (by Dan)
On 10/2/19 5:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when the call to sysfs_create_link fails the error exit
> path returns an uninitialized value in variable ret. Fix this by
> returning the error code returned from the failed call to
> sysfs_create_link.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 32fd90c40768 ("nvme: change locking for the per-subsystem controller list")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/nvme/host/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 63b37d08ac98..f6acbff3e3bc 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2540,8 +2540,9 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
> list_add_tail(&subsys->entry, &nvme_subsystems);
> }
>
> - if (sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj,
> - dev_name(ctrl->device))) {
> + ret = sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj,
> + dev_name(ctrl->device));
> + if (ret) {
> dev_err(ctrl->device,
> "failed to create sysfs link from subsystem.\n");
> goto out_put_subsystem;
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-10-05 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 12:43 [PATCH] nvme: fix uninitialized return of ret when sysfs_create_link fails Colin King
2019-10-05 0:02 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e3dc55-6e6e-a4e8-f082-4b57144467af@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=colin.king@canonical.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).