From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: sagi@grimberg.me, israelr@mellanox.com,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
shlomin@mellanox.com, hch@lst.de
Subject: Re: [PATCH v2 1/1] nvme-rdma: Fix max_hw_sectors calculation
Date: Fri, 27 Sep 2019 23:22:12 +0200 [thread overview]
Message-ID: <20190927212212.GD16819@lst.de> (raw)
In-Reply-To: <1569099499-24017-1-git-send-email-maxg@mellanox.com>
On Sat, Sep 21, 2019 at 11:58:19PM +0300, Max Gurtovoy wrote:
> By default, the NVMe/RDMA driver should support max io_size of 1MiB (or
> upto the maximum supported size by the HCA). Currently, one will see that
> /sys/class/block/<bdev>/queue/max_hw_sectors_kb is 1020 instead of 1024.
>
> A non power of 2 value can cause performance degradation due to
> unnecessary splitting of IO requests and unoptimized allocation units.
>
> The number of pages per MR has been fixed here, so there is no longer any
> need to reduce max_sectors by 1.
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-09-27 21:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 20:58 [PATCH v2 1/1] nvme-rdma: Fix max_hw_sectors calculation Max Gurtovoy
2019-09-27 21:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927212212.GD16819@lst.de \
--to=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).