From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75BCC4360C for ; Sun, 6 Oct 2019 10:12:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F0AB20673 for ; Sun, 6 Oct 2019 10:12:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LP6xnILf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F0AB20673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ysAg9moaHVstE2eYYVtT3lrZiut1DXN0LbjRA7re0ug=; b=LP6xnILfHXve3p 6bUMGZipmOFqEc0Sljo7hgYBdsU38bIWFmzWe6ys5z/EKWUe3UCkJd6pYrzKaEWDbcNpi6ibl1tg4 UXJorh3z53VfcgDgl8yIPFJLj4QqeF3rtLQ2S2OB9RfOlXJ3C7STwF/xFN5UwwXDYSOSmVrNChdIT 2tS3GwjvplvUpXgCKzyqYhh5XpawJa1IpUHrdo7ip1oqPsuDd+xyX46OGuyefNsGizfWuObYY3Bp6 Gkh+7xdoDNwJQ3RX6iHV2LLQY/+63Eo30VdOqWpY6a4KHC/1iQNB119JDehA0fmPqUcHk5Sfv4RDm BtqS9K/mhR+OC9ziquiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iH3X3-00086J-OS; Sun, 06 Oct 2019 10:12:53 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iH3X2-00086A-RE; Sun, 06 Oct 2019 10:12:52 +0000 Date: Sun, 6 Oct 2019 03:12:52 -0700 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH] nvme: define struct for __nvme_submit_sync_cmd() Message-ID: <20191006101252.GB30175@infradead.org> References: <20191001231346.18518-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191001231346.18518-1-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Oct 01, 2019 at 04:13:46PM -0700, Chaitanya Kulkarni wrote: > Over the period of time __nvme_submit_sync_cmd() function has grown to > accept large number of paratements. The function __nvme_submit_sync_cmd() > now takes 10 parameters. This patch consolidates all the parameters into > one defined structure. > > This makes calls to the same function easy to read and improves overall > code readability. This makes the code both a lot more unreadable and a lot larger. What is the point? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme