From: Bjorn Helgaas <helgaas@kernel.org>
To: Jian-Hong Pan <jian-hong@endlessm.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
stable@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
linux@endlessm.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] Revert "nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T"
Date: Thu, 31 Oct 2019 08:28:53 -0500 [thread overview]
Message-ID: <20191031132853.GA46011@google.com> (raw)
In-Reply-To: <20191031093408.9322-1-jian-hong@endlessm.com>
On Thu, Oct 31, 2019 at 05:34:09PM +0800, Jian-Hong Pan wrote:
> Since commit 253eaf4faaaa ("PCI/MSI: Fix incorrect MSI-X masking on
> resume") is merged, we can revert the previous quirk now.
253eaf4faaaa is pending on my pci/msi branch, planned to be merged
during the v5.5 merge window.
This revert patch must not be merged before 253eaf4faaaa. The easiest
way to do that would be for me to merge this one as well; otherwise
we have to try to make things happen in the right order during the
merge window.
If the NVMe folks ack this idea and the patch, I'd be happy to merge
it.
> This reverts commit 19ea025e1d28c629b369c3532a85b3df478cc5c6.
>
> Fixes: 19ea025e1d28 ("nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T")
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204887
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> Cc: stable@vger.kernel.org
> ---
> v2:
> Re-send for mailing failure
>
> drivers/nvme/host/core.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index fa7ba09dca77..94bfbee1e5f7 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2404,16 +2404,6 @@ static const struct nvme_core_quirk_entry core_quirks[] = {
> .vid = 0x14a4,
> .fr = "22301111",
> .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> - },
> - {
> - /*
> - * This Kingston E8FK11.T firmware version has no interrupt
> - * after resume with actions related to suspend to idle
> - * https://bugzilla.kernel.org/show_bug.cgi?id=204887
> - */
> - .vid = 0x2646,
> - .fr = "E8FK11.T",
> - .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> }
> };
>
> --
> 2.23.0
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-31 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 9:34 [PATCH v2] Revert "nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T" Jian-Hong Pan
2019-10-31 13:28 ` Bjorn Helgaas [this message]
2019-10-31 13:30 ` Christoph Hellwig
2019-11-01 22:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031132853.GA46011@google.com \
--to=helgaas@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jian-hong@endlessm.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).