From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Keith Busch <kbusch@kernel.org>
Cc: ming.lei@redhat.com, helgaas@kernel.org, hch@lst.de,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH 0/4] nvme: Threaded interrupt handling improvements
Date: Mon, 2 Dec 2019 18:05:38 +0100 [thread overview]
Message-ID: <20191202170538.juq745vddzsouufb@linutronix.de> (raw)
In-Reply-To: <20191130170222.GA5273@redsun51.ssa.fujisawa.hgst.com>
On 2019-12-01 02:02:22 [+0900], Keith Busch wrote:
> On Fri, Nov 29, 2019 at 06:05:45PM +0100, Sebastian Andrzej Siewior wrote:
> > Ach okay. But I wouldn't consider it as a "bug" if your threaded handler
> > returns IRQ_HANDLED and requires a longer period of time. Thsi seems
> > fine to me.
> > The SDHCI driver has a case where the interrupt thread waits for another
> > interrupt (from its primary handler) in order to make progress.
>
> Yes, that uses a driver specific way to handle that. This patch series
> provides nvme specific handling for long running irq threads.
That might be a misunderstanding. I think if your threaded-IRQ handler
is running legitimately for longer period of time (and making progress)
and IRQ core's "nobody-care" detector shuts it down then the detector
might need a tweak.
The worst thing that could happen, is that the RT tasks run for too long
and the scheduler punishes them to protect against run-away-tasks (the
default limit is at 950ms RT task time within 1 second,
sched_rt_runtime_us).
Sebastian
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-02 17:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 17:58 [PATCH 0/4] nvme: Threaded interrupt handling improvements Keith Busch
2019-11-27 17:58 ` [PATCH 1/4] PCI/MSI: Export __pci_msix_desc_mask_irq Keith Busch
2019-11-28 2:42 ` Sagi Grimberg
2019-11-28 3:41 ` Keith Busch
2019-11-28 7:17 ` Christoph Hellwig
2019-11-27 17:58 ` [PATCH 2/4] nvme/pci: Mask legacy and MSI in threaded handler Keith Busch
2019-11-28 3:39 ` Ming Lei
2019-11-28 3:48 ` Keith Busch
2019-11-28 3:58 ` Ming Lei
2019-11-28 4:14 ` Keith Busch
2019-11-28 8:41 ` Ming Lei
2019-11-27 17:58 ` [PATCH 3/4] nvme/pci: Mask MSIx interrupts for threaded handling Keith Busch
2019-11-28 7:19 ` Christoph Hellwig
2019-11-27 17:58 ` [PATCH 4/4] nvme/pci: Spin threaded interrupt completions Keith Busch
2019-11-28 2:46 ` Sagi Grimberg
2019-11-28 3:28 ` Keith Busch
2019-11-28 3:51 ` Ming Lei
2019-11-28 3:58 ` Keith Busch
2019-11-28 7:22 ` Christoph Hellwig
2019-11-29 9:13 ` Sebastian Andrzej Siewior
2019-11-30 18:10 ` Keith Busch
2019-12-02 1:10 ` Ming Lei
2019-12-02 1:30 ` Keith Busch
2019-12-02 16:51 ` Sebastian Andrzej Siewior
2019-11-28 7:50 ` [PATCH 0/4] nvme: Threaded interrupt handling improvements Christoph Hellwig
2019-11-28 17:59 ` Keith Busch
2019-11-29 8:30 ` Christoph Hellwig
2019-11-29 9:46 ` Sebastian Andrzej Siewior
2019-11-29 16:27 ` Keith Busch
2019-11-29 17:05 ` Sebastian Andrzej Siewior
2019-11-30 17:02 ` Keith Busch
2019-12-02 17:05 ` Sebastian Andrzej Siewior [this message]
2019-12-02 17:12 ` Christoph Hellwig
2019-12-02 18:06 ` Keith Busch
2019-12-03 7:40 ` Christoph Hellwig
2019-12-02 19:57 ` Sebastian Andrzej Siewior
2019-12-03 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202170538.juq745vddzsouufb@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).