From: Keith Busch <kbusch@kernel.org>
To: linux-nvme@lists.infradead.org
Cc: Keith Busch <kbusch@kernel.org>,
bigeasy@linutronix.de, ming.lei@redhat.com, hch@lst.de,
sagi@grimberg.me
Subject: [RFC PATCH 3/3] nvme/pci: Poll for new completions in irq thread
Date: Tue, 3 Dec 2019 07:22:06 +0900 [thread overview]
Message-ID: <20191202222206.2225-4-kbusch@kernel.org> (raw)
In-Reply-To: <20191202222206.2225-1-kbusch@kernel.org>
A controller may post new completions while the irq thread is handling
previously seen completions. Have the irq thread poll for these as long
as new completions are available. This improves bandwidth and reduces
CPU time spend in irq context.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 634c96bafb70..44d8f701dce8 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1040,7 +1040,9 @@ static irqreturn_t nvme_irq_thread(int irq, void *data)
{
struct nvme_queue *nvmeq = data;
- nvme_irq(irq, data);
+ while (nvme_irq(irq, data) != IRQ_NONE && !need_resched())
+ cpu_relax();
+
if (to_pci_dev(nvmeq->dev->dev)->msix_enabled)
__pci_msix_desc_mask_irq(irq_get_msi_desc(irq), 0);
else
--
2.21.0
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-02 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 22:22 [RFC PATCH 0/3] nvme threaded interrupt improvements Keith Busch
2019-12-02 22:22 ` [RFC PATCH 1/3] nvme/pci: Poll the cq in the primary irq handler Keith Busch
2019-12-03 7:50 ` Christoph Hellwig
2019-12-03 9:39 ` Sebastian Andrzej Siewior
2019-12-03 11:50 ` Keith Busch
2019-12-03 10:09 ` Sebastian Andrzej Siewior
2019-12-03 11:16 ` Keith Busch
2019-12-04 10:21 ` Ming Lei
2019-12-02 22:22 ` [RFC PATCH 2/3] nvme/pci: Remove use_threaded_interrupts parameter Keith Busch
2019-12-02 22:22 ` Keith Busch [this message]
2019-12-03 10:17 ` [RFC PATCH 3/3] nvme/pci: Poll for new completions in irq thread Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202222206.2225-4-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).