From: "hch@lst.de" <hch@lst.de>
To: "Singh, Balbir" <sblbir@amazon.com>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"Sangaraju, Someswarudu" <ssomesh@amazon.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [RFC][PATCH] nvme/core: Notify udev about capacity change
Date: Tue, 3 Dec 2019 07:54:21 +0100 [thread overview]
Message-ID: <20191203065421.GA23032@lst.de> (raw)
In-Reply-To: <0a5fc287a4ac392b9b192402e6786e7129b9d5f2.camel@amazon.com>
On Mon, Dec 02, 2019 at 11:35:47PM +0000, Singh, Balbir wrote:
> On Fri, 2019-11-29 at 09:24 +0100, Christoph Hellwig wrote:
> > I don't think this makes sense, and they way it has been done in
> > virtio_blk and xen-blkfront is an utter hack. Please first add a
> > properly documented block helper, and then make sure it doesn't send the
> > even for the first call that moves from a 0 capacity. SCSI also will
> > need updating to use the helper.
>
> Makes sense, I am wondering if I should refactor
> set_capacity to __set_capacity and have set_capacity do notifcations
> for
>
> oldsize vs newsize where oldsize is not 0
I pretty much hate the set_capacity name to start with, so what about
a more descriptive name for new the helper? blk_set_capacity?
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-03 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 0:27 [RFC][PATCH] nvme/core: Notify udev about capacity change Balbir Singh
2019-11-29 8:24 ` Christoph Hellwig
2019-12-02 23:35 ` Singh, Balbir
2019-12-03 6:54 ` hch [this message]
2019-12-03 7:26 ` Chaitanya Kulkarni
2019-12-03 7:34 ` hch
2019-12-03 12:43 ` Johannes Thumshirn
2019-12-03 12:52 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203065421.GA23032@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sblbir@amazon.com \
--cc=ssomesh@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).