From: Keith Busch <kbusch@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH V2] nvme: Add support for ACRE Command Interrupted status
Date: Thu, 5 Dec 2019 01:07:37 +0900 [thread overview]
Message-ID: <20191204160737.GA1791@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <04835a2e-1769-36c9-63b8-173f247c862b@suse.de>
On Wed, Dec 04, 2019 at 02:26:06PM +0100, Hannes Reinecke wrote:
> > Why is the controller returning the same error so many times? Are we
> > not waiting the requested delay timed? If so, the controller told us
> > retrying should be successful.
> >
> > It is possible we kick the requeue list early if one command error
> > has a valid CRD, but a subsequent retryable command does not. Is that
> > what's happening?
> >
> No. The problem is that CRD needs to be observed _in all cases_ whenever
> we get a COMMAND INTERRUPTED status.
> Currently we're only observing CRD when multipathing is _not_ active,
> which is wrong.
>
> And this is what the patch is trying to achieve.
Right, I totally got that part.
I just don't understand this follow-up from John that I cropped it out
of my original reply:
> The alternative is to stop incrementing nvme_req(req)->retries in nvme_retry_req() when CRD is set.
>
> @@ -258,8 +258,8 @@ static void nvme_retry_req(struct request *req)
> crd = (nvme_req(req)->status & NVME_SC_CRD) >> 11;
> if (ns && crd)
> delay = ns->ctrl->crdt[crd - 1] * 100;
>-
>- nvme_req(req)->retries++;
>+ else
>+ nvme_req(req)->retries++;
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-04 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 19:12 [PATCH V2] nvme: Add support for ACRE Command Interrupted status Meneghini, John
2019-12-03 17:38 ` Meneghini, John
2019-12-03 21:00 ` Keith Busch
2019-12-04 13:26 ` Hannes Reinecke
2019-12-04 14:48 ` Meneghini, John
2019-12-04 16:07 ` Keith Busch [this message]
2019-12-04 18:33 ` Meneghini, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204160737.GA1791@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).