From: Keith Busch <kbusch@kernel.org>
To: linux-nvme@lists.infradead.org
Cc: sagi@grimberg.me, bigeasy@linutronix.de, ming.lei@redhat.com,
Keith Busch <kbusch@kernel.org>,
tglx@linutronix.de, hch@lst.de
Subject: [PATCHv3 3/4] nvme/pci: Remove use_threaded_interrupts
Date: Tue, 10 Dec 2019 02:56:21 +0900 [thread overview]
Message-ID: <20191209175622.1964-4-kbusch@kernel.org> (raw)
In-Reply-To: <20191209175622.1964-1-kbusch@kernel.org>
The nvme threaded interrupt handling provides quick completions for
latency sensitive workloads, and threaded handlers for more IOPS intensive
ones. Remove the use_threaded_interrupts nvme module parameter since
leaving it disabled should not be providing a benefit.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/pci.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index e415fadf7331..28e08c5ab412 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -40,9 +40,6 @@
#define NVME_MAX_KB_SZ 4096
#define NVME_MAX_SEGS 127
-static int use_threaded_interrupts;
-module_param(use_threaded_interrupts, int, 0);
-
static bool use_cmb_sqes = true;
module_param(use_cmb_sqes, bool, 0444);
MODULE_PARM_DESC(use_cmb_sqes, "use controller's memory buffer for I/O SQes");
@@ -1519,13 +1516,8 @@ static int queue_request_irq(struct nvme_queue *nvmeq)
struct pci_dev *pdev = to_pci_dev(nvmeq->dev->dev);
int nr = nvmeq->dev->ctrl.instance;
- if (use_threaded_interrupts) {
- return pci_request_irq(pdev, nvmeq->cq_vector, nvme_irq_check,
- nvme_irq_thread, nvmeq, "nvme%dq%d", nr, nvmeq->qid);
- } else {
- return pci_request_irq(pdev, nvmeq->cq_vector, nvme_irq,
- NULL, nvmeq, "nvme%dq%d", nr, nvmeq->qid);
- }
+ return pci_request_irq(pdev, nvmeq->cq_vector, nvme_irq_check,
+ nvme_irq_thread, nvmeq, "nvme%dq%d", nr, nvmeq->qid);
}
static void nvme_init_queue(struct nvme_queue *nvmeq, u16 qid)
--
2.21.0
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-09 17:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 17:56 [PATCHv3 0/4] nvme pci interrupt handling improvements Keith Busch
2019-12-09 17:56 ` [PATCHv3 1/4] nvme/pci: Disable interrupts for threaded handler Keith Busch
2019-12-10 15:12 ` Daniel Wagner
2019-12-10 15:28 ` Sebastian Andrzej Siewior
2019-12-10 15:54 ` Keith Busch
2019-12-10 16:44 ` Daniel Wagner
2019-12-10 16:57 ` Keith Busch
2019-12-10 17:11 ` Daniel Wagner
2019-12-12 9:09 ` Christoph Hellwig
2019-12-12 15:53 ` Keith Busch
2019-12-09 17:56 ` [PATCHv3 2/4] nvme/pci: Complete commands from primary handler Keith Busch
2019-12-10 20:00 ` Sagi Grimberg
2019-12-10 20:25 ` Keith Busch
2019-12-10 21:14 ` Sagi Grimberg
2019-12-11 17:35 ` Keith Busch
2019-12-12 0:40 ` Sagi Grimberg
2019-12-12 1:02 ` Keith Busch
2019-12-12 22:55 ` Ming Lei
2019-12-12 23:30 ` Keith Busch
2019-12-13 0:52 ` Ming Lei
2019-12-12 9:14 ` Christoph Hellwig
2019-12-09 17:56 ` Keith Busch [this message]
2019-12-12 9:14 ` [PATCHv3 3/4] nvme/pci: Remove use_threaded_interrupts Christoph Hellwig
2019-12-12 15:45 ` Keith Busch
2019-12-18 7:29 ` Ming Lei
2019-12-18 15:50 ` Keith Busch
2019-12-19 1:10 ` Ming Lei
2019-12-09 17:56 ` [PATCHv3 4/4] nvme/pci: Poll threaded completions Keith Busch
2019-12-10 17:43 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209175622.1964-4-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).