From: Keith Busch <kbusch@kernel.org>
To: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 1/1] nvme-pci: Hold cq_poll_lock while completing CQEs
Date: Fri, 28 Feb 2020 01:35:10 +0900 [thread overview]
Message-ID: <20200227163510.GA25532@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <1582772023-67704-1-git-send-email-bijan.mottahedeh@oracle.com>
On Wed, Feb 26, 2020 at 06:53:43PM -0800, Bijan Mottahedeh wrote:
> Avoid scheduling a polling thread if it has cqe's to complete, otherwise
> another thread may free enough tags out of order, allowing a queue wrap.
>
> This is an interim solution. Longer term, the two-pass completion should
> be fixed. It was done that way when submit and complete processing were
> using the same spinlock, so reducing the critical section was helpful,
> but that's not needed anymore.
>
> Fixes: dabcefab45d3 ("nvme: provide optimized poll function for separate poll queues")
> Signed-off-by: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
Thanks, applied to a new nvme-5.6-rc4 branch.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-27 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 2:53 [PATCH v2 1/1] nvme-pci: Hold cq_poll_lock while completing CQEs Bijan Mottahedeh
2020-02-27 16:35 ` Keith Busch [this message]
2020-02-29 18:57 ` Christoph Hellwig
2020-03-02 19:04 ` Bijan Mottahedeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227163510.GA25532@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=bijan.mottahedeh@oracle.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).