From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Rui Feng <rui_feng@realsil.com.cn>,
linux-pci@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] mmc: core: Initial support for SD express card/host
Date: Thu, 16 Jul 2020 18:13:58 +0200 [thread overview]
Message-ID: <20200716161358.GA3135454@kroah.com> (raw)
In-Reply-To: <20200716141534.30241-1-ulf.hansson@linaro.org>
On Thu, Jul 16, 2020 at 04:15:34PM +0200, Ulf Hansson wrote:
> +int mmc_send_if_cond_pcie(struct mmc_host *host, u32 ocr)
> +{
> + u32 resp = 0;
> + u8 pcie_bits = 0;
> + int ret;
> +
> + if (host->caps2 & MMC_CAP2_SD_EXP) {
> + /* Probe card for SD express support via PCIe. */
> + pcie_bits = 0x10;
> + if (host->caps2 & MMC_CAP2_SD_EXP_1_2V)
> + /* Probe also for 1.2V support. */
> + pcie_bits = 0x30;
> + }
> +
> + ret = __mmc_send_if_cond(host, ocr, pcie_bits, &resp);
> + if (ret)
> + return 0;
> +
> + /* Continue with the SD express init, if the card supports it. */
> + resp &= 0x3000;
> + if (pcie_bits && resp) {
> + if (resp == 0x3000)
0x3000 should be some defined value, right? Otherwise it just looks
like magic bits :)
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -60,6 +60,8 @@ struct mmc_ios {
> #define MMC_TIMING_MMC_DDR52 8
> #define MMC_TIMING_MMC_HS200 9
> #define MMC_TIMING_MMC_HS400 10
> +#define MMC_TIMING_SD_EXP 11
> +#define MMC_TIMING_SD_EXP_1_2V 12
>
> unsigned char signal_voltage; /* signalling voltage (1.8V or 3.3V) */
>
> @@ -172,6 +174,9 @@ struct mmc_host_ops {
> */
> int (*multi_io_quirk)(struct mmc_card *card,
> unsigned int direction, int blk_size);
> +
> + /* Initialize an SD express card, mandatory for MMC_CAP2_SD_EXP. */
> + int (*init_sd_express)(struct mmc_host *host, struct mmc_ios *ios);
> };
>
> struct mmc_cqe_ops {
> @@ -357,6 +362,8 @@ struct mmc_host {
> #define MMC_CAP2_HS200_1_2V_SDR (1 << 6) /* can support */
> #define MMC_CAP2_HS200 (MMC_CAP2_HS200_1_8V_SDR | \
> MMC_CAP2_HS200_1_2V_SDR)
> +#define MMC_CAP2_SD_EXP (1 << 7) /* SD express via PCIe */
BIT(7)?
> +#define MMC_CAP2_SD_EXP_1_2V (1 << 8) /* SD express 1.2V */
BIT(8)?
thanks,
greg k-h
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-07-16 16:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:15 [PATCH] mmc: core: Initial support for SD express card/host Ulf Hansson
2020-07-16 16:13 ` Greg Kroah-Hartman [this message]
2020-07-16 17:04 ` Ulf Hansson
2020-07-16 17:21 ` Greg Kroah-Hartman
2020-07-16 18:22 ` Arnd Bergmann
2020-07-24 10:06 ` Ulf Hansson
2020-07-24 13:35 ` Arnd Bergmann
2020-07-24 13:44 ` Christoph Hellwig
2020-08-21 12:40 ` Ulf Hansson
2020-08-24 1:04 ` 答复: " 冯锐
2020-08-24 6:33 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716161358.GA3135454@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=rui_feng@realsil.com.cn \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).