From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH 2/2] nvme: use driver pdu command for passthrough
Date: Wed, 17 Mar 2021 07:47:06 +0100 [thread overview]
Message-ID: <20210317064706.GB14498@lst.de> (raw)
In-Reply-To: <20210316170632.4161183-2-kbusch@kernel.org>
On Tue, Mar 16, 2021 at 10:06:32AM -0700, Keith Busch wrote:
> @@ -724,14 +727,6 @@ static void nvme_assign_write_stream(struct nvme_ctrl *ctrl,
> req->q->write_hints[streamid] += blk_rq_bytes(req) >> 9;
> }
>
> -static inline void nvme_setup_passthrough(struct request *req,
> - struct nvme_command *cmd)
> -{
> - memcpy(cmd, nvme_req(req)->cmd, sizeof(*cmd));
> - /* passthru commands should let the driver set the SGL flags */
> - cmd->common.flags &= ~NVME_CMD_SGL_ALL;
> -}
I think we need to keep the sanitization of common.flags here.
The rest looks good.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-17 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 17:06 [PATCH 1/2] nvme-pci: allocate nvme_command within driver pdu Keith Busch
2021-03-16 17:06 ` [PATCH 2/2] nvme: use driver pdu command for passthrough Keith Busch
2021-03-16 17:44 ` Sagi Grimberg
2021-03-16 18:08 ` Keith Busch
2021-03-17 6:47 ` Christoph Hellwig [this message]
2021-03-17 9:46 ` Kanchan Joshi
2021-03-17 14:06 ` Keith Busch
2021-03-16 17:44 ` [PATCH 1/2] nvme-pci: allocate nvme_command within driver pdu Sagi Grimberg
2021-03-16 18:02 ` Christoph Hellwig
2021-03-16 18:13 ` Keith Busch
2021-03-16 18:27 ` Sagi Grimberg
2021-03-16 18:34 ` Christoph Hellwig
2021-03-17 6:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317064706.GB14498@lst.de \
--to=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).