From: Keith Busch <kbusch@kernel.org>
To: Yuanyuan Zhong <yzhong@purestorage.com>
Cc: Chaitanya.Kulkarni@wdc.com, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
cachen@purestorage.com
Subject: Re: [PATCH v2] nvme-core: initialize status to NVME_SC_HOST_PATH_ERROR
Date: Thu, 15 Apr 2021 13:17:26 -0700 [thread overview]
Message-ID: <20210415201726.GB2452080@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20210415193030.GA2452080@dhcp-10-100-145-180.wdc.com>
On Thu, Apr 15, 2021 at 12:30:30PM -0700, Keith Busch wrote:
> On Wed, Apr 14, 2021 at 11:08:33AM -0600, Yuanyuan Zhong wrote:
> > Block layer blk_end_sync_rq() silently drops blk_status_t error.
> > When ->queue_rq returns error, nvme driver should set nvme status
> > explicitly. Otherwise the passthrough command may take the stale
> > status as result. A typical value zero will be interpreted as
> > NVME_SC_SUCCESS, despite the dispatching error from ->queue_rq.
> >
> > Instead of trying to fix it for every error return, this change
> > initialize the status to NVME_SC_HOST_PATH_ERROR during
> > nvme_clear_nvme_request().
>
> It doesn't look like these types of errors are unique to nvme. Could we
> not just have blk_execute_rq() return an error instead?
The following enables all callers to know if queue_rq() failed:
---
diff --git a/block/blk-exec.c b/block/blk-exec.c
index beae70a0e5e5..6d12524a91f9 100644
--- a/block/blk-exec.c
+++ b/block/blk-exec.c
@@ -21,7 +21,7 @@ static void blk_end_sync_rq(struct request *rq, blk_status_t error)
{
struct completion *waiting = rq->end_io_data;
- rq->end_io_data = NULL;
+ rq->end_io_data = ERR_PTR(blk_status_to_errno(error));
/*
* complete last, if this is a stack request the process (and thus
@@ -73,7 +73,7 @@ EXPORT_SYMBOL_GPL(blk_execute_rq_nowait);
* Insert a fully prepared request at the back of the I/O scheduler queue
* for execution and wait for completion.
*/
-void blk_execute_rq(struct gendisk *bd_disk, struct request *rq, int at_head)
+int blk_execute_rq(struct gendisk *bd_disk, struct request *rq, int at_head)
{
DECLARE_COMPLETION_ONSTACK(wait);
unsigned long hang_check;
@@ -87,5 +87,6 @@ void blk_execute_rq(struct gendisk *bd_disk, struct request *rq, int at_head)
while (!wait_for_completion_io_timeout(&wait, hang_check * (HZ/2)));
else
wait_for_completion_io(&wait);
+ return PTR_ERR_OR_ZERO(rq->end_io_data);
}
EXPORT_SYMBOL(blk_execute_rq);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 1a6f89d1110c..9ed540d168af 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -933,7 +933,7 @@ extern int blk_rq_map_kern(struct request_queue *, struct request *, void *, uns
extern int blk_rq_map_user_iov(struct request_queue *, struct request *,
struct rq_map_data *, const struct iov_iter *,
gfp_t);
-extern void blk_execute_rq(struct gendisk *, struct request *, int);
+extern int blk_execute_rq(struct gendisk *, struct request *, int);
extern void blk_execute_rq_nowait(struct gendisk *,
struct request *, int, rq_end_io_fn *);
--
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-15 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 23:45 [PATCH] nvme-core: initialize status to NVME_SC_HOST_PATH_ERROR Yuanyuan Zhong
2021-04-13 3:19 ` Chaitanya Kulkarni
2021-04-14 17:08 ` [PATCH v2] " Yuanyuan Zhong
2021-04-15 19:30 ` Keith Busch
2021-04-15 20:17 ` Keith Busch [this message]
2021-04-15 22:11 ` Yuanyuan Zhong
2021-04-15 22:58 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415201726.GB2452080@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=cachen@purestorage.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).