From: "hch@lst.de" <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"hare@suse.de" <hare@suse.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH V2 1/2] nvme: add generic helper to store secret
Date: Wed, 7 Jun 2023 07:03:43 +0200 [thread overview]
Message-ID: <20230607050343.GB19879@lst.de> (raw)
In-Reply-To: <2ce728ac-54b7-f59d-a0c0-b585767a9428@grimberg.me>
On Tue, Jun 06, 2023 at 09:43:16AM +0300, Sagi Grimberg wrote:
> I understand, but at a point where the commonality becomes confusing
> it can get counter productive.
Agreed. As-is I don't think the code has very sane structure after
the patch. If we want to consolidate the code, I'd make the sectet and
key fields a two-element array, with an enum for the indices. With
that might be possible to share the code without needing extra branches
for which case we're handling.
next prev parent reply other threads:[~2023-06-07 5:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:51 [PATCH V2 0/2] nvme: dhchap_secret code cleanup Chaitanya Kulkarni
2023-06-05 6:51 ` [PATCH V2 1/2] nvme: add generic helper to store secret Chaitanya Kulkarni
2023-06-05 7:52 ` Hannes Reinecke
2023-06-05 22:30 ` Sagi Grimberg
2023-06-06 3:24 ` Chaitanya Kulkarni
2023-06-06 6:43 ` Sagi Grimberg
2023-06-07 3:44 ` Chaitanya Kulkarni
2023-06-07 5:03 ` hch [this message]
2023-06-05 6:51 ` [PATCH V2 2/2] nvme-core: use macro defination to define dev attr Chaitanya Kulkarni
2023-06-05 7:55 ` Hannes Reinecke
2023-06-05 8:01 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607050343.GB19879@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).