From: John Meneghini <jmeneghi@redhat.com>
To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk,
kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
emilne@redhat.com, hare@kernel.org
Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
jmeneghi@redhat.com, jrani@purestorage.com,
randyj@purestorage.com
Subject: [PATCH v4 6/6] nvme: multipath: pr_notice when iopolicy changes
Date: Tue, 14 May 2024 13:53:22 -0400 [thread overview]
Message-ID: <20240514175322.19073-7-jmeneghi@redhat.com> (raw)
In-Reply-To: <20240514175322.19073-1-jmeneghi@redhat.com>
Send a pr_notice when ever the iopolicy on a subsystem
is changed. This is important for support reasons. It
is fully expected that users will be changing the iopolicy
with active IO in progress.
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
---
drivers/nvme/host/multipath.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index e9330bb1990b..0286e44a081f 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -67,6 +67,10 @@ static int nvme_activate_iopolicy(struct nvme_subsystem *subsys, int iopolicy)
}
}
mutex_unlock(&subsys->lock);
+
+ pr_notice("%s: %s enable %d status %d for subsysnqn %s\n", __func__,
+ nvme_iopolicy_names[iopolicy], enable, ret, subsys->subnqn);
+
return ret;
}
@@ -890,6 +894,8 @@ void nvme_subsys_iopolicy_update(struct nvme_subsystem *subsys, int iopolicy)
{
struct nvme_ctrl *ctrl;
+ int old_iopolicy = READ_ONCE(subsys->iopolicy);
+
WRITE_ONCE(subsys->iopolicy, iopolicy);
mutex_lock(&nvme_subsystems_lock);
@@ -898,6 +904,10 @@ void nvme_subsys_iopolicy_update(struct nvme_subsystem *subsys, int iopolicy)
nvme_mpath_clear_ctrl_paths(ctrl);
}
mutex_unlock(&nvme_subsystems_lock);
+
+ pr_notice("%s: changed from %s to %s for subsysnqn %s\n", __func__,
+ nvme_iopolicy_names[old_iopolicy], nvme_iopolicy_names[iopolicy],
+ subsys->subnqn);
}
static ssize_t nvme_subsys_iopolicy_store(struct device *dev,
--
2.39.3
prev parent reply other threads:[~2024-05-14 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 17:53 [PATCH v4 0/6] block,nvme: queue-depth and latency I/O schedulers John Meneghini
2024-05-14 17:53 ` [PATCH v4 1/6] nvme: multipath: Implemented new iopolicy "queue-depth" John Meneghini
2024-05-20 14:46 ` Keith Busch
2024-05-14 17:53 ` [PATCH v4 2/6] nvme: multipath: only update ctrl->nr_active when using queue-depth iopolicy John Meneghini
2024-05-14 17:53 ` [PATCH v4 3/6] nvme: multipath: Invalidate current_path when changing iopolicy John Meneghini
2024-05-14 17:53 ` [PATCH v4 4/6] block: track per-node I/O latency John Meneghini
2024-05-14 17:53 ` [PATCH v4 5/6] nvme: add 'latency' iopolicy John Meneghini
2024-05-14 17:53 ` John Meneghini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514175322.19073-7-jmeneghi@redhat.com \
--to=jmeneghi@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=jrani@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).