Re: [PATCH v24 00/20] nvme-tcp receive offloads

From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Aurelien Aptel <aaptel@nvidia.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"hch@lst.de" <hch@lst.de>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"axboe@fb.com" <axboe@fb.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"aurelien.aptel@gmail.com" <aurelien.aptel@gmail.com>,
	Shai Malin <smalin@nvidia.com>,
	"malin1024@gmail.com" <malin1024@gmail.com>,
	Or Gerlitz <ogerlitz@nvidia.com>, Yoray Zack <yorayz@nvidia.com>,
	Boris Pismenny <borisp@nvidia.com>,
	Gal Shalom <galshalom@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	"edumazet@google.com" <edumazet@google.com>
Subject: Re: [PATCH v24 00/20] nvme-tcp receive offloads
Date: Thu, 18 Apr 2024 08:29:27 +0000	[thread overview]
Message-ID: <27e21214-7523-43e2-a3a4-0b6327190fec@nvidia.com> (raw)
In-Reply-To: <20240409155907.2726de60@kernel.org>

On 4/9/2024 3:59 PM, Jakub Kicinski wrote:
> On Tue, 9 Apr 2024 22:35:51 +0000 Chaitanya Kulkarni wrote:
>> blktests seems to be the right framework to add all the testcases to
>> cover the targeted subsystem(s) for this patchset. Daniel from Suse has
>> already posted an RFC (see [1]) to add support for blktests so we can
>> use real controllers for better test coverage. We will be discussing
>> that at LSFMM session this year in detail.
> 
> No preference on the framework or where the tests live, FWIW.
> 
>> With this support in the blktest framework, we can definitely generate
>> right test-coverage for the tcp-offload that can be run by anyone who
>> has this H/W. Just like I run NVMe tests on the code going from NVMe
>> tree to block tree for every pull request, we are planning to run new
>> nvme tcp offload specific tests regularly on NVMe tree. We will be happy
>> to provide the H/W to distros who are supporting this feature in order
>> to make testing easier for others as well.
> 
> You're not sending these patches to the distros, you're sending them
> to the upstream Linux kernel. And unfortunately we don't have a test
> lab where we could put your HW, so it's on you. To be clear all you
> need to do is periodically build and test certain upstream branches
> and report results. By "report" all I mean is put a JSON file with the
> result somewhere we can HTTP GET. KernelCI has been around for a while,
> I don't think this is a crazy ask.

That should be doable, we can run the tests and make the results
available for others to access in JASON format. Just to
clarify what you mean by the Kernel CI ? what I understood you want
our tests to run and provide the results, still not clear about the
Kernel CI involvement in this process, can you please elaborate ?

-ck