From: Sagi Grimberg <sagi@grimberg.me>
To: mwilck@suse.com, Hannes Reinecke <hare@suse.de>,
Keith Busch <kbusch@kernel.org>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
linux-nvme@lists.infradead.org,
Enzo Matsumiya <ematsumiya@suse.de>
Subject: Re: [PATCH 06/10] nvme-cli: add generic logging functionality
Date: Mon, 15 Mar 2021 10:45:47 -0700 [thread overview]
Message-ID: <28137147-9fce-1581-e55d-b190f7666cfa@grimberg.me> (raw)
In-Reply-To: <20210306003624.21102-7-mwilck@suse.com>
> From: Martin Wilck <mwilck@suse.com>
>
> Add a msg() macro that allows more flexible customization of logging
> both at build time and at run time. Allow several log levels, using
> the well-known standard sylog levels. Also optionally allow printing
> of log timestamps.
>
> Put '#define LOG_FUNCNAME' before '#include "util/log.h"' to enable printing
> the name of the calling function before the log message.
>
> Use this functionality in the fabrics code for now, wherever fprintf(stderr, ...)
> had been used.
>
> No functional change except changing the output channel of 554db7d ("print
> device name when creating a persistent device") from stdout to stderr.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> Makefile | 2 +-
> fabrics.c | 85 ++++++++++++++++++++++++++++-----------------------
> util/log.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> util/log.h | 34 +++++++++++++++++++++
I think it makes sense to do a wider sweep also for nvme.c and friends
no?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-15 17:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 0:36 [PATCH 00/10] Some minor fixes/additions for nvme-cli mwilck
2021-03-06 0:36 ` [PATCH 01/10] nvme-discover: lookup existing persistent controllers mwilck
2021-03-15 17:38 ` Sagi Grimberg
2021-03-15 17:43 ` Martin Wilck
2021-03-16 9:36 ` Hannes Reinecke
2021-03-06 0:36 ` [PATCH 02/10] nvme-discover: assume device given on command line is persistent mwilck
2021-03-15 17:41 ` Sagi Grimberg
2021-03-15 17:51 ` Martin Wilck
2021-03-06 0:36 ` [PATCH 03/10] do_discover: free cfg.device when resetting it mwilck
2021-03-06 0:36 ` [PATCH 04/10] nvme-connect-all(1): fix documentation for --quiet/-S mwilck
2021-03-08 7:12 ` Chaitanya Kulkarni
2021-03-15 17:44 ` Sagi Grimberg
2021-03-06 0:36 ` [PATCH 05/10] nvme: add some simplifying macros for __attribute__((cleanup())) mwilck
2021-03-08 7:10 ` Chaitanya Kulkarni
2021-03-15 17:44 ` Sagi Grimberg
2021-03-06 0:36 ` [PATCH 06/10] nvme-cli: add generic logging functionality mwilck
2021-03-08 7:15 ` Chaitanya Kulkarni
2021-03-08 7:17 ` Chaitanya Kulkarni
2021-03-15 17:45 ` Sagi Grimberg [this message]
2021-03-16 8:14 ` Martin Wilck
2021-03-06 0:36 ` [PATCH 07/10] nvme: convert some function arguments from "char *" to "const char *" mwilck
2021-03-08 7:13 ` Chaitanya Kulkarni
2021-03-15 17:46 ` Sagi Grimberg
2021-03-06 0:36 ` [PATCH 08/10] fabrics: use "const char *" in struct config mwilck
2021-03-08 7:08 ` Chaitanya Kulkarni
2021-03-15 17:46 ` Sagi Grimberg
2021-03-06 0:36 ` [PATCH 09/10] fabrics: fix some memory leaks mwilck
2021-03-08 7:13 ` Chaitanya Kulkarni
2021-03-15 17:46 ` Sagi Grimberg
2021-03-06 0:36 ` [PATCH 10/10] fabrics: fix invalid memory access in discover_from_conf_file() mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28137147-9fce-1581-e55d-b190f7666cfa@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=ematsumiya@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).