From: Max Gurtovoy <maxg@mellanox.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
<linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-core: get rid of the unused variable
Date: Sun, 1 Sep 2019 11:20:09 +0300 [thread overview]
Message-ID: <55e83bf3-572b-63b1-427b-65b7a521e2f5@mellanox.com> (raw)
In-Reply-To: <20190831001013.8581-1-chaitanya.kulkarni@wdc.com>
On 8/31/2019 3:10 AM, Chaitanya Kulkarni wrote:
> This patch fixes the following compilation warning:-
>
> drivers/nvme//host/core.c: In function ‘nvme_complete_rq’:
> drivers/nvme//host/core.c:264:18: warning: unused variable ‘ns’
> [-Wunused-variable]
> struct nvme_ns *ns = req->q->queuedata;
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> drivers/nvme/host/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 0b1ff8d54e48..ddf99345e3d8 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -261,7 +261,6 @@ static void nvme_retry_req(struct request *req)
> void nvme_complete_rq(struct request *req)
> {
> blk_status_t status = nvme_error_status(req);
> - struct nvme_ns *ns = req->q->queuedata;
I can't find this code anywhere, but anyway this must go out.
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
>
> trace_nvme_complete_rq(req);
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-01 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 0:10 [PATCH] nvme-core: get rid of the unused variable Chaitanya Kulkarni
2019-09-01 8:20 ` Max Gurtovoy [this message]
2019-09-02 16:14 ` Christoph Hellwig
2019-09-04 18:27 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55e83bf3-572b-63b1-427b-65b7a521e2f5@mellanox.com \
--to=maxg@mellanox.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).