From: Sagi Grimberg <sagi@grimberg.me>
To: Keith Busch <kbusch@kernel.org>
Cc: Edmund Nadolski <edmund.nadolski@intel.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/5] nvme: Prevent resets during paused states
Date: Thu, 5 Sep 2019 13:42:21 -0700 [thread overview]
Message-ID: <67e7eb83-c4e2-ebd8-9c82-c5e038e3ca9f@grimberg.me> (raw)
In-Reply-To: <20190905203546.GB25467@localhost.localdomain>
>> Also, seems a bit "acrobatic" to set the state to RESETTING without
>> really resetting it (and then change it back to LIVE before you do
>> actually resetting it).
>
> We can think of a CSTS.PP as the device internally resetting itself to
> activate firmware.
Can the reset flush the fw activation work? I'm trying to understand if
this state games are the best solution here...
>> Would it make sense to look at nvme_ctrl_pp_status when
>> scheduling a reset in nvme_reset_ctrl? Just a thought..
>
> We have to be able to reset if we decide CSTS.PP is stuck, fw activation
> timeout.
See above.
>>> - nvme_reset_ctrl(ctrl);
>>> + if (nvme_change_ctrl_state(ctrl, NVME_CTRL_LIVE))
>>> + nvme_reset_ctrl(ctrl);
>>
>> How can this state change not succeed? ctrl removal?
>
> Right, we can't prevent a transition to a deleting state.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-05 20:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 14:26 [PATCH 1/5] nvme: Restart request timers in resetting state Keith Busch
2019-09-05 14:26 ` [PATCH 2/5] nvme: Prevent resets during paused states Keith Busch
2019-09-05 20:23 ` Sagi Grimberg
2019-09-05 20:35 ` Keith Busch
2019-09-05 20:42 ` Sagi Grimberg [this message]
2019-09-05 14:26 ` [PATCH 3/5] nvme-pci: Free tagset if no IO queues Keith Busch
2019-09-05 20:24 ` Sagi Grimberg
2019-09-05 20:40 ` Keith Busch
2019-09-05 20:43 ` Sagi Grimberg
2019-09-05 14:26 ` [PATCH 4/5] nvme: Remove ADMIN_ONLY state Keith Busch
2019-09-05 14:26 ` [PATCH 5/5] nvme: Wait for reset state when required Keith Busch
2019-09-05 15:57 ` James Smart
2019-09-05 20:47 ` Sagi Grimberg
2019-09-05 20:55 ` Keith Busch
2019-09-05 20:13 ` [PATCH 1/5] nvme: Restart request timers in resetting state Sagi Grimberg
2019-09-05 20:25 ` Keith Busch
2019-09-05 20:39 ` Sagi Grimberg
2019-09-05 21:36 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e7eb83-c4e2-ebd8-9c82-c5e038e3ca9f@grimberg.me \
--to=sagi@grimberg.me \
--cc=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).