From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
GR-QLogic-Storage-Upstream
<GR-QLogic-Storage-Upstream@marvell.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Hannes Reinecke <hare@suse.de>,
Nilesh Javali <njavali@marvell.com>,
Arun Easi <aeasi@marvell.com>
Subject: Re: [RFC] qla2xxx: Add dev_loss_tmo kernel module options
Date: Tue, 20 Apr 2021 14:51:27 +0000 [thread overview]
Message-ID: <83B4512E-17ED-4061-B27E-B2EE71E772CC@oracle.com> (raw)
In-Reply-To: <20210420123723.bregf4debvyincpo@beryllium.lan>
Hi Daniel,
> On Apr 20, 2021, at 7:37 AM, Daniel Wagner <dwagner@suse.de> wrote:
>
> Hi Randy,
>
> On Mon, Apr 19, 2021 at 09:19:13AM -0700, Randy Dunlap wrote:
>>> +int ql2xdev_loss_tmo = 60;
>>> +module_param(ql2xdev_loss_tmo, int, 0444);
>>> +MODULE_PARM_DESC(ql2xdev_loss_tmo,
>>> + "Time to wait for device to recover before reporting\n"
>>> + "an error. Default is 60 seconds\n");
>>
>> No need for the \n in the quoted string. Just change it to a space.
>
> I just followed the current style in this file. I guess this style
> question is up to the maintainers to decide what they want.
>
> Thanks,
> Daniel
>
Some of the instance in the file needed \n for readability of Module options. In this particular instance,
I would rather move \n so that the message is displayed on same line and default option on second line
Something like following
>>> "Time to wait for device to recover before reporting an error.\n"
>>> "Default is 60 seconds\n");
With the change mentioned above I am ok with this patch. You can add my R-B when you send official patch.
--
Himanshu Madhani Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-20 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:00 [RFC] qla2xxx: Add dev_loss_tmo kernel module options Daniel Wagner
2021-04-19 16:19 ` Randy Dunlap
2021-04-20 12:37 ` Daniel Wagner
2021-04-20 14:51 ` Himanshu Madhani [this message]
2021-04-20 15:35 ` Randy Dunlap
2021-04-20 17:27 ` Benjamin Block
2021-04-20 17:35 ` Roman Bolshakov
2021-04-20 18:28 ` Daniel Wagner
2021-04-21 0:25 ` [EXT] " Arun Easi
2021-04-21 7:56 ` Daniel Wagner
2021-04-27 9:51 ` Daniel Wagner
2021-04-27 22:35 ` Arun Easi
2021-04-28 7:17 ` Daniel Wagner
2021-04-28 14:51 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83B4512E-17ED-4061-B27E-B2EE71E772CC@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=aeasi@marvell.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).