From: hare@suse.de (Hannes Reinecke)
Subject: [PATCHv3] nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Tue, 13 Aug 2019 19:03:35 +0200 [thread overview]
Message-ID: <955adc31-6d46-3187-54ac-8d342c117bf8@suse.de> (raw)
In-Reply-To: <20190813170144.GA10269@lst.de>
On 8/13/19 7:01 PM, Christoph Hellwig wrote:
> On Mon, Aug 12, 2019@09:51:47AM +0200, Hannes Reinecke wrote:
>> If the DNR bit is set we should not retry the command, even if
>> the standard status evaluation indicates so.
>
> What problem is this even trying to solve? Nothing in the
> documentation of BLK_STS_TARGET says it should be retried any more
> or less than other error code.
>
> If you really care about a retryable vs not retryable distinction
> at the block layer we need to propagate the equivalent of the DNR
> bit.
>
That was my worry, too.
But I wasn't sure if that was the direction we should be going.
Personally, I'd be more than happy to add a flag for non-retryable errors.
Let's see how it would look like ...
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2019-08-13 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 7:51 [PATCHv3] nvme: Return BLK_STS_TARGET if the DNR bit is set Hannes Reinecke
2019-08-12 23:37 ` Nadolski, Edmund
2019-08-13 6:32 ` Sagi Grimberg
2019-08-13 14:15 ` Keith Busch
2019-08-13 16:37 ` Sagi Grimberg
2019-08-13 16:56 ` Hannes Reinecke
2019-08-13 17:01 ` Christoph Hellwig
2019-08-13 17:03 ` Hannes Reinecke [this message]
2019-08-13 17:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955adc31-6d46-3187-54ac-8d342c117bf8@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).