From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Hou Pu <houpu.main@gmail.com>,
"amit.engel@dell.com" <amit.engel@dell.com>
Cc: "Ran.Anner@dell.com" <Ran.Anner@dell.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: nvmet_set_error ignores error_loc NVMET_NO_ERROR_LOC
Date: Fri, 2 Apr 2021 23:07:21 +0000 [thread overview]
Message-ID: <BYAPR04MB49657D66C4F7D7E2360A335E867A9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210402073531.23753-1-houpu.main@gmail.com
On 4/2/21 00:36, Hou Pu wrote:
> Hi Amit,
> I think the specification does not tell us which error should go into the
> error log page (or does it?). It is decided by implementation and current
> implementation only records errors with an error_loc other than
> NVMET_NO_ERROR_LOC.
>
> So the problem here is that:
> If some errors which do not set error_loc should go into the error log page,
> we need some change here.
>
> Thanks,
> Hou
>
>
We set the error based on the request so I think for all the errors we
do have
a error location. Have you encountered a place in current code that sets the
error which is not related to any request ?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-02 23:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 8:57 nvmet_set_error ignores error_loc NVMET_NO_ERROR_LOC Engel, Amit
2021-03-16 18:26 ` Chaitanya Kulkarni
2021-04-02 7:35 ` Hou Pu
2021-04-02 23:07 ` Chaitanya Kulkarni [this message]
2021-04-04 6:25 ` Engel, Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB49657D66C4F7D7E2360A335E867A9@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Ran.Anner@dell.com \
--cc=amit.engel@dell.com \
--cc=houpu.main@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).