linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvmet: don't check iosqes,iocqes for discovery controllers
Date: Tue, 16 Mar 2021 03:38:23 +0000	[thread overview]
Message-ID: <BYAPR04MB4965A1560B3258E7E4DD560E866B9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210315223451.380437-1-sagi@grimberg.me

On 3/15/21 15:34, Sagi Grimberg wrote:
> From the base spec, Figure 78:
> "Controller Configuration, these fields are defined as parameters to
> configure an "I/O Controller (IOC)" and not to configure a "Discovery
> Controller (DC)".
> ...
> "If the controller does not support I/O queues, then this field shall
> be read-only with a value of 0h"
>
> Just have this check for I/O controllers.
>
> Fixes: a07b4970f464 ("nvmet: add a generic NVMe target")
> Reported-by: Belanger, Martin <Martin.Belanger@dell.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-03-16  3:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 22:34 [PATCH] nvmet: don't check iosqes,iocqes for discovery controllers Sagi Grimberg
2021-03-16  3:38 ` Chaitanya Kulkarni [this message]
2021-03-18  4:35 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB4965A1560B3258E7E4DD560E866B9@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).