From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09CEC32767 for ; Sat, 4 Jan 2020 22:32:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B107F22B48 for ; Sat, 4 Jan 2020 22:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j+sQvQuq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="mtSogubE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="kXwJyGfv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B107F22B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date :Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=BwJihtrGv6OUO/9BhKHsvhfWwjQfxHpl2jkT+kZ0Op8=; b=j+sQvQuqU2rFDh 9KaAIQKNjSkVRoxDXmDNTxnQl7cfzzFMOssa8TLRUOZZbOQx+9wY/gODjWUjtM6sSicEm1fVPxrV+ mD0v3GVRFdSmCCTA96T+3IzBbRZBcvhi20xiy4Ax2crYLhP3dzCYLNhXpsfXu9yyeAH2jzcoRy0hn 0OtNUn4DoyKDNBEr+V4aXavh5qvmSi4x0YwvTaAjW0B6pysIaJurUBm92Bw8vl4aWEBFCyy0PvMqD ltkFTYcIlhWKU6YAr1IGyH1PCxRuaM43kLdayQ4UrdzqczSD67GNcK7cYSKbodfvmMBbwwIFM7i2F p2X+NU8ynEyMe4nma5NQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inry4-0003oj-O8; Sat, 04 Jan 2020 22:32:24 +0000 Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inry2-0003oR-P9 for linux-nvme@lists.infradead.org; Sat, 04 Jan 2020 22:32:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1578177167; x=1609713167; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=mAhAlJWlyxPqt2COxTwNBjasBE1ma/qqkGtFJwa8jro=; b=mtSogubEydr5Wp0YXbNv2xVohmhJt1ey+7kXzsueheW+OWI2IeBoqYL/ Ud5U7BLGTzppl1gBoKXvhp9SMHUJEz1QhPLZLJKUzZ+EHB/JuFWvnxelt EkzlxzkBtskhMpKIe4+l5eBWWJSffHRMqO16QfhQjxoqWeu1zzbzUfqHB aOiiJ0WTI8V7NaqieuZ5HuDFZtv5JYpuMDFU6P91mUpTGYE6V032/vNMt GU1hNi9KzEarLnWOrse1PRwedQko8ItmK5WJGslcgwwUYPSlRoYKgppvy rvGCASBI4eVYPKzMy+dAB2nJNfvOwNtVAsB08/stDMYbBfNqV0f5Rbd8J g==; IronPort-SDR: ZR28yCo+jp8WaqB+2NmZv2qRczatGOIzcjCV8TSVhf/jEhmE8LBPlWwYnRTwWtLT1zCCU6VyKN qNUgb/7SbSpLEpwtPxC0Zx+K3Q9ueIBx3lBbGrsKXJJDkF09onau0/jrFaUJNAI/+Gx+kz5P/y UoxgI5hEux6qYz/i5yKytM3T6CBZ5AMkr/s/71miUEDCzS/bplNtBXwM/CTBi9rMPzFA0x2hbb uulAyNlODBtPT3w5Cwjrkd/WqQOuZlhbERq9nKJ9OkSLRjwlSGiUjTYf3Xs91KP2wXMTiYUxwY GP4= X-IronPort-AV: E=Sophos;i="5.69,396,1571673600"; d="scan'208";a="228377991" Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hgst.iphmx.com with ESMTP; 05 Jan 2020 06:32:37 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gR+xKYD2dPuL1Rk3lvQZtBCH1/7fNtAzGwFnFCzNEltwADmot/NLDz2yrXdoefUtaQtkRukqcDy897t8wbGM8ctWkYA23NW40XmKIFTJCCEnqJszvxDtEajkHUOrxuOafiHWGXrhTIKYZ+yQG4joDa09+zKS8+aQKk6NlvyYyhTZpbC3dEoVzn+CMm+rqYA5VeHEkzN1kG4PomAEyJapTyJ88/pUsPdNErND0GlgfLZc1MXOStanGnPN5goWeKUmmn05DamNxhRRZI6hKVlmUfGVpZLRI4hh2+ITPW+NxtL++n5uQiXMlL+rEl7UxUYGdTWOsQsPwenzAz5RHWCosQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mAhAlJWlyxPqt2COxTwNBjasBE1ma/qqkGtFJwa8jro=; b=QyqW5pCSpf5QNF9RgSiavQ2CbY3aINrgEBdbnzCk0KXCwXRuunFCGfa2eYiqzFplVL35+1iXXxhjOHOzBbKbsC1s9oxSddly+xGOM4b7aaH2a9NUQ5Q0RwtGenBbr+Kq2LXaAuwQsDEIr1KItDfHsKXoyaCFtGtNhJsdC984hIFjtMXli/xQWKTwTC1Nk9Y4BL14D0Mg8plLkn4hlFMMrlT4kvyLiTg2hbYmQQHIVv9Q38yD13OrQrdKmBQmAGZozxEfrOCahAiL+vplJiDEFK8LfxAX2KyFBMv1OLA4D4ikT0kxnL0rrrLOa4hZe7ntaHBxj3coZ0GqlU5Wm7AXCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mAhAlJWlyxPqt2COxTwNBjasBE1ma/qqkGtFJwa8jro=; b=kXwJyGfv4kGBQ3GIKdfRMWnSZ1BEPFBosOIYlljUtQVTZkaErz36BH/T84UPgdFJm+FH04wPDwU1TRTYor03Iz39l6/oh3TYIwXWQONx45s0LKvf0FzWCc3S36ma+yfdzocSdPWi2DNQ9D/7S/Y/U2UgLbIu9fsXwbCZuLMAhvU= Received: from BYAPR04MB5749.namprd04.prod.outlook.com (20.179.57.21) by BYAPR04MB4184.namprd04.prod.outlook.com (52.135.205.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.15; Sat, 4 Jan 2020 22:32:13 +0000 Received: from BYAPR04MB5749.namprd04.prod.outlook.com ([fe80::a8ea:4ba9:cb57:e90f]) by BYAPR04MB5749.namprd04.prod.outlook.com ([fe80::a8ea:4ba9:cb57:e90f%5]) with mapi id 15.20.2602.015; Sat, 4 Jan 2020 22:32:13 +0000 From: Chaitanya Kulkarni To: "Singh, Balbir" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change Thread-Topic: [resend v1 1/5] block/genhd: Notify udev about capacity change Thread-Index: AQHVwUG9qzxAaxFzwka5YkVHh6Dxxg== Date: Sat, 4 Jan 2020 22:32:13 +0000 Message-ID: References: <20200102075315.22652-1-sblbir@amazon.com> <20200102075315.22652-2-sblbir@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Chaitanya.Kulkarni@wdc.com; x-originating-ip: [199.255.45.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 627881fa-f3e1-460a-e03e-08d79165f1fe x-ms-traffictypediagnostic: BYAPR04MB4184: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02723F29C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(189003)(199004)(66946007)(7696005)(54906003)(110136005)(9686003)(316002)(76116006)(66446008)(66476007)(66556008)(64756008)(8936002)(55016002)(86362001)(81166006)(53546011)(81156014)(6506007)(8676002)(71200400001)(186003)(4326008)(26005)(2906002)(33656002)(5660300002)(4744005)(52536014)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB4184; H:BYAPR04MB5749.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T6KUjJM9S4/g7P/Y7HFBkRvDKP37Gec9l+mdCPw09N6D341CIc4J6DoqUoaEc/4Sm3hb5dbLzhD5FEcvuxPP/5BAX9M6f9JewE0QUUweh55MAg9A0sLd4mX7zfN4Uh81nNIFMBX4CopZUWqxfIm6DWti19WPq3CDqjPRZ3rDVNonnFfIerKQ5UAV/XwdwCPbhxMJrzefdl8hJG4UrnNuorNJaSWOj27KrDuq47h+4O8hJt8F3cbeD1mFWrF+elVCBn8S6H9+KFpX/xIffhoYdmO34U/PrU9BJqyBPzNY2IzMqnkZNj7XojKvlNeRKR8ImaSSweevDC0QOyP4HRqgn28jO3/5OQhsE1+XNPdhmzqO+jn5UiGHEJf8nEJ44/jUn9aeDu10yaXy5A5BPoOtgUiUbyO0WEWnytNLtny2OE/qua2UA6jHzpjVsn0pmhbZ x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 627881fa-f3e1-460a-e03e-08d79165f1fe X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2020 22:32:13.2992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5umaWUCbxTebkov9Pf6/Ll9ekCqWe7evliHwJ0sBXEhT4qoftl1E3Dztlq0a4ig72taxx/BCaAU79TypTF204fUxjbqAOVPLYl8dNXxsSzI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4184 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200104_143222_858794_A21F0364 X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "axboe@kernel.dk" , "Sangaraju, Someswarudu" , "jejb@linux.ibm.com" , "hch@lst.de" , "mst@redhat.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 01/03/2020 08:44 PM, Singh, Balbir wrote: >> >Since disk_set_capacity(() is on the same line as set_capacity() >> >we should follow the same convention, which is :- >> > >> >1. Avoid exporting symbol. >> >2. Mark new function in-line. >> > >> >Unless there is a very specific reason for breaking the pattern. >> > > I don't see the benefit of marking it as inline. I expect this code to be > potentially expanded to provide callbacks into file system code for expansion > (something you brought up), marking it as inline might be a limitation. > That can be done as a prep patch when framework is ready. > I'd rather not clutter the headers with this code, but I am open to what the > maintainers think as well. > Okay. > Balbir Singh. > > _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme