From: "Liang, Prike" <Prike.Liang@amd.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device supports it
Date: Wed, 21 Apr 2021 08:41:55 +0000 [thread overview]
Message-ID: <BYAPR12MB3238A5758B18B061204F264EFB479@BYAPR12MB3238.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAAd53p4r45fZ4ewCko_Q-mO92omBZkEiPpyyc2SYRXH+6WpEKg@mail.gmail.com>
[AMD Public Use]
According to BIOS guys the _PR3 should be always implemented for NVMe device on the onwards ASIC. This solution seems more simple and looks good to me.
Reviewed-by: Prike Liang <Prike.Liang@amd.com>
Thanks,
Prike
> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Monday, April 19, 2021 2:58 PM
> To: Christoph Hellwig <hch@lst.de>
> Cc: Keith Busch <kbusch@kernel.org>; Jens Axboe <axboe@fb.com>; Sagi
> Grimberg <sagi@grimberg.me>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Liang, Prike <Prike.Liang@amd.com>; S-k,
> Shyam-sundar <Shyam-sundar.S-k@amd.com>; open list:NVM EXPRESS
> DRIVER <linux-nvme@lists.infradead.org>; open list <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device
> supports it
>
> On Mon, Apr 19, 2021 at 2:50 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > On Fri, Apr 16, 2021 at 05:13:44PM +0800, Kai-Heng Feng wrote:
> > > On AMD platforms that use s2idle, NVMe timeouts on s2idle resume,
> > > because their SMU FW may cut off NVMe power during sleep.
> >
> > We're already have a discussion on a proper quirk for thse broken
> > platforms on the linux-nvme list, please take part in that discussion.
>
> Thanks. I didn't notice v5 was sent the to mailing list.
> As of now, AMD folks are also reviewing this, and I believe this approach is
> less quirky.
>
> Kai-Heng
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-21 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 9:13 [PATCH v2] nvme: Favor D3cold for suspend if NVMe device supports it Kai-Heng Feng
2021-04-19 6:50 ` Christoph Hellwig
2021-04-19 6:57 ` Kai-Heng Feng
2021-04-21 8:41 ` Liang, Prike [this message]
2021-04-21 17:38 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3238A5758B18B061204F264EFB479@BYAPR12MB3238.namprd12.prod.outlook.com \
--to=prike.liang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kai.heng.feng@canonical.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).