From: Akinobu Mita <akinobu.mita@gmail.com>
To: Matthew Wilcox <willy@infradead.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
linux-hwmon@vger.kernel.org, Linux PM <linux-pm@vger.kernel.org>,
"open list:TI WILINK WIRELES..."
<linux-wireless@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 01/12] add helpers for kelvin to/from Celsius conversion
Date: Tue, 17 Dec 2019 00:02:32 +0900 [thread overview]
Message-ID: <CAC5umyiZGzu3h9tUrSRWh6c6WLyUvXtdDvThw+VHoTjffBVNZA@mail.gmail.com> (raw)
In-Reply-To: <20191216032540.GY32169@bombadil.infradead.org>
2019年12月16日(月) 12:25 Matthew Wilcox <willy@infradead.org>:
>
> > +static inline long milli_kelvin_to_millicelsius(long t)
> > +{
> > + return t + ABSOLUTE_ZERO_MILLICELSIUS;
> > +}
>
> Why is there an underscore between 'milli' and 'kelvin', but not between
> 'milli' and 'celsius'?
Because these function names are derived from the existing macros in
linux/thermal.h.
Does anyone have a preference for the underscore in these function names?
1. underscore between unit prefix and 'kelvin,
no underscore between unit prefix and 'celsius'
(e.g. milli_kelvin_to_millicelsius, deci_kelvin_to_millicelsius, ...)
2. underscore between unit prefix and 'kelvin,
underscore between unit prefix and 'celsius'
(e.g. milli_kelvin_to_milli_celsius, deci_kelvin_to_milli_celsius, ...)
3. no underscore between unit prefix and 'kelvin,
no underscore between unit prefix and 'celsius'
(e.g. millikelvin_to_millicelsius, decikelvin_to_millicelsius, ...)
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next parent reply other threads:[~2019-12-16 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.18297.1576387017.2486.linux-nvme@lists.infradead.org>
[not found] ` <20191216032540.GY32169@bombadil.infradead.org>
2019-12-16 15:02 ` Akinobu Mita [this message]
2019-12-15 5:16 [PATCH v4 00/12] add header file for kelvin to/from Celsius conversion helpers Akinobu Mita
2019-12-15 5:16 ` [PATCH v4 01/12] add helpers for kelvin to/from Celsius conversion Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC5umyiZGzu3h9tUrSRWh6c6WLyUvXtdDvThw+VHoTjffBVNZA@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).