On Mar 12 00:49, Keith Busch wrote:
> On Thu, Mar 11, 2021 at 06:51:26AM +0100, Klaus Jensen wrote:
> > On Mar 10 11:57, Keith Busch wrote:
> > > +	if (id->dmrsl)
> > > +		ctrl->max_discard_sectors = le32_to_cpu(id->dmrsl);
> > 
> > Since DMRSL is in terms of LBAs, should this use nvme_lba_to_sect?
> 
> We need a namespace for that, but we only have a controller for this
> Identify.

Ah yes.

I remember now that I also complained loudly about this mistake in the
spec when we implemented it in QEMU.