From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Minwoo Im" <minwoo.im.dev@gmail.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Keith Busch" <kbusch@kernel.org>, "Jens Axboe" <axboe@fb.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Kanchan Joshi" <joshiiitr@gmail.com>,
"Javier González" <javier.gonz@samsung.com>
Subject: Re: [PATCH V2 0/1] nvme: introduce generic per-namespace chardev
Date: Wed, 7 Apr 2021 10:00:43 +0000 [thread overview]
Message-ID: <YG2CyoOWSTFPOi0c@x1-carbon.lan> (raw)
In-Reply-To: <20210407093923.GA31210@lst.de>
On Wed, Apr 07, 2021 at 11:39:23AM +0200, Christoph Hellwig wrote:
> On Wed, Apr 07, 2021 at 07:36:22AM +0000, Niklas Cassel wrote:
> > The SCSI generic devices are named /dev/sgX while the SCSI block devices
> > are named /dev/sd*, so the names are more distinct compared to /dev/nvme*
> > and /dev/nvme-generic-*.
> >
> > A "regular" Linux user who writes /dev/sd<tab> will not see the SCSI
> > generic devices, but with the current proposal, if he writes
> > /dev/nvme<tab>, he will see the NVMe generic devices.
> >
> > I just had a gut feeling that this could cause confusion in the future.
> > However, I trust your experience and judgement more than my gut feeling.
>
> Should we call the nodes /dev/ng* ?
Man... naming things is the hardest thing about software development ;)
It would solve the problem of them being too similarly named.
And if we document this somewhere, it makes sense that SCSI generic
is /dev/sg and NVMe generic is /dev/ng...
The only "bad" thing is that we take up a very generic (pun intended)
name in the /dev/ namespace. The acronym might conflict with something
else in the future. But trying to predict the future seems silly,
so I can't come up with any argument against your naming proposal :)
Kind regards,
Niklas
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-07 10:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 6:48 [PATCH V2 0/1] nvme: introduce generic per-namespace chardev Minwoo Im
2021-04-06 6:48 ` [PATCH V2 1/1] " Minwoo Im
2021-04-07 13:15 ` Christoph Hellwig
2021-04-07 14:11 ` Minwoo Im
2021-04-07 14:21 ` Christoph Hellwig
2021-04-07 15:35 ` Minwoo Im
2021-04-07 15:40 ` Christoph Hellwig
2021-04-07 15:44 ` Minwoo Im
2021-04-07 15:47 ` Minwoo Im
2021-04-07 16:48 ` Christoph Hellwig
2021-04-07 16:59 ` Minwoo Im
2021-04-07 17:09 ` Minwoo Im
2021-04-07 17:14 ` Christoph Hellwig
2021-04-08 7:11 ` Javier González
2021-04-08 7:26 ` Christoph Hellwig
2021-04-08 10:26 ` Javier González
2021-04-08 11:27 ` Christoph Hellwig
2021-04-08 11:46 ` Javier González
2021-04-08 12:41 ` Minwoo Im
2021-04-06 9:01 ` [PATCH V2 0/1] " Niklas Cassel
2021-04-06 13:35 ` Minwoo Im
2021-04-06 14:59 ` Christoph Hellwig
2021-04-06 16:23 ` Minwoo Im
2021-04-07 6:00 ` Christoph Hellwig
2021-04-07 6:02 ` Minwoo Im
2021-04-07 7:36 ` Niklas Cassel
2021-04-07 9:39 ` Christoph Hellwig
2021-04-07 10:00 ` Niklas Cassel [this message]
2021-04-07 10:34 ` Damien Le Moal
2021-04-07 11:50 ` Javier González
2021-04-06 14:13 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG2CyoOWSTFPOi0c@x1-carbon.lan \
--to=niklas.cassel@wdc.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).