From: Greg KH <gregkh@linuxfoundation.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH stable/5.4..5.8] nvme-mpath: replace direct_make_request with generic_make_request
Date: Fri, 9 Apr 2021 11:43:27 +0200 [thread overview]
Message-ID: <YHAhv+ruvQwB3bM9@kroah.com> (raw)
In-Reply-To: <a1674400-b265-6506-71cb-fd893d3f52c4@grimberg.me>
On Wed, Apr 07, 2021 at 04:18:30PM -0700, Sagi Grimberg wrote:
>
> > > > > Hence, we need to fix all the kernels that were before submit_bio_noacct was
> > > > > introduced.
> > > >
> > > > Why can we not just add submit_bio_noacct to the 5.4 kernel to correct
> > > > this? What commit id is that?
> > >
> > > Hey Greg,
> > >
> > > submit_bio_noacct was applied as part of a rework by Christoph that I
> > > didn't feel was suitable as a stable candidate. The commit-id is:
> > > ed00aabd5eb9fb44d6aff1173234a2e911b9fead
> >
> > submit_bio_noacct really is just a new name for generic_make_request,
> > as the old one was horribly misleading. So this does use
> > submit_bio_noacct, just with its old name.
>
> commit ed00aabd5eb9fb44d6aff1173234a2e911b9fead does not apply
> cleanly on any of these kernels, so I think it's better to take this
> small one-liner instead of trying to fit a commit that changes the
> name treewide.
>
> Greg, what is your preference? backporting
> ed00aabd5eb9fb44d6aff1173234a2e911b9fead to the various kernels
> or to take this isolated one?
I took just this change now, thanks.
greg k-h
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-09 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 20:08 [PATCH stable/5.4..5.8] nvme-mpath: replace direct_make_request with generic_make_request Sagi Grimberg
2021-04-03 6:10 ` Greg KH
2021-04-07 1:04 ` Sagi Grimberg
2021-04-07 5:28 ` Christoph Hellwig
2021-04-07 23:18 ` Sagi Grimberg
2021-04-09 9:43 ` Greg KH [this message]
2021-04-09 9:33 ` Patch "nvme-mpath: replace direct_make_request with generic_make_request" has been added to the 5.4-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHAhv+ruvQwB3bM9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).