From: Matthew Wilcox <willy@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
hare@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Pankaj Raghav <kernel@pankajraghav.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH 5/5] nvme: enable logical block size > PAGE_SIZE
Date: Tue, 14 May 2024 06:08:27 +0100 [thread overview]
Message-ID: <ZkLxy6QUc5BB_adf@casper.infradead.org> (raw)
In-Reply-To: <993991e6-7f06-4dfd-b5d7-554b9574384c@suse.de>
On Mon, May 13, 2024 at 06:07:55PM +0200, Hannes Reinecke wrote:
> On 5/12/24 11:16, Luis Chamberlain wrote:
> > On Sat, May 11, 2024 at 07:43:26PM -0700, Luis Chamberlain wrote:
> > > I'll try next going above 512 KiB.
> >
> > At 1 MiB NVMe LBA format we crash with the BUG_ON(sectors <= 0) on bio_split().
>
> Ah. MAX_BUFS_PER_PAGE getting in the way.
That doesn't make sense. We will need something like this patch for
filesystems which use large folios with buffer_heads. But for a 1MB
block size device, we should have one buffer_head per folio.
next prev parent reply other threads:[~2024-05-14 5:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:29 [PATCH 0/5] enable bs > ps for block devices hare
2024-05-10 10:29 ` [PATCH 1/5] fs/mpage: use blocks_per_folio instead of blocks_per_page hare
2024-05-10 22:19 ` Matthew Wilcox
2024-05-11 9:12 ` Hannes Reinecke
2024-05-10 10:29 ` [PATCH 2/5] fs/mpage: avoid negative shift for large blocksize hare
2024-05-10 22:24 ` Matthew Wilcox
2024-05-11 9:13 ` Hannes Reinecke
2024-05-10 10:29 ` [PATCH 3/5] block/bdev: lift restrictions on supported blocksize hare
2024-05-10 22:25 ` Matthew Wilcox
2024-05-11 9:15 ` Hannes Reinecke
2024-05-11 22:57 ` Luis Chamberlain
2024-05-11 22:54 ` Luis Chamberlain
2024-05-10 10:29 ` [PATCH 4/5] block/bdev: enable large folio support for large logical block sizes hare
2024-05-10 22:35 ` Matthew Wilcox
2024-05-11 9:18 ` Hannes Reinecke
2024-05-11 5:07 ` kernel test robot
2024-05-11 7:04 ` kernel test robot
2024-05-10 10:29 ` [PATCH 5/5] nvme: enable logical block size > PAGE_SIZE hare
2024-05-10 22:37 ` Matthew Wilcox
2024-05-11 9:18 ` Hannes Reinecke
2024-05-11 23:11 ` Luis Chamberlain
2024-05-11 23:09 ` Luis Chamberlain
2024-05-11 23:30 ` Matthew Wilcox
2024-05-11 23:51 ` Luis Chamberlain
2024-05-12 2:43 ` Luis Chamberlain
2024-05-12 9:16 ` Luis Chamberlain
2024-05-13 16:07 ` Hannes Reinecke
2024-05-13 21:05 ` Luis Chamberlain
2024-05-13 23:07 ` Hannes Reinecke
2024-05-24 10:04 ` Hannes Reinecke
2024-05-14 5:08 ` Matthew Wilcox [this message]
2024-05-13 13:43 ` Hannes Reinecke
2024-05-13 14:32 ` Luis Chamberlain
2024-05-11 23:12 ` [PATCH 0/5] enable bs > ps for block devices Luis Chamberlain
2024-05-30 13:37 ` Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkLxy6QUc5BB_adf@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=kent.overstreet@linux.dev \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).