From: israelr@mellanox.com (Israel Rukshin)
Subject: [PATCH] nvme-cli/fabrics: Add tos param to connect cmd
Date: Wed, 14 Aug 2019 07:42:28 +0000 [thread overview]
Message-ID: <b6fa103b-bac4-f0d7-5b43-8a8fff8227b5@mellanox.com> (raw)
In-Reply-To: <82499575-a1d7-35aa-1cae-32d1fdbc3ab0@grimberg.me>
On 8/13/2019 7:43 PM, Sagi Grimberg wrote:
>
>> Added 'tos' to 'connect' command so users can specify the type of
>> service.
>>
>> usage examples:
>> nvme connect --tos=0 --transport=rdma --traddr=10.0.1.1 --nqn=test-nvme
>> nvme connect -T 0 -t rdma -a 10.0.1.1 -n test_nvme
>>
>
> What if you run this with a kernel that doesn't support tos yet?
You will get:
nvme_fabrics: unknown parameter or missing value 'tos=0' in ctrl
creation request
next prev parent reply other threads:[~2019-08-14 7:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:17 [PATCH 0/5 V2] nvme: Add type of service (TOS) configuration Israel Rukshin
2019-08-13 13:17 ` [PATCH] nvme-cli/fabrics: Add tos param to connect cmd Israel Rukshin
2019-08-13 16:43 ` Sagi Grimberg
2019-08-14 7:42 ` Israel Rukshin [this message]
2019-08-13 13:17 ` [PATCH 1/5] nvme-fabrics: Add type of service (TOS) configuration Israel Rukshin
2019-08-13 16:40 ` Sagi Grimberg
2019-08-13 17:55 ` James Smart
2019-08-13 13:17 ` [PATCH 2/5] nvme-rdma: Add TOS for rdma transport Israel Rukshin
2019-08-13 16:40 ` Sagi Grimberg
2019-08-13 13:17 ` [PATCH 3/5] nvme-tcp: Use struct nvme_ctrl directly Israel Rukshin
2019-08-13 16:41 ` Sagi Grimberg
2019-08-13 13:17 ` [PATCH 4/5] nvme-tcp: Add TOS for tcp transport Israel Rukshin
2019-08-13 16:41 ` Sagi Grimberg
2019-08-13 13:17 ` [PATCH 5/5] nvmet-tcp: " Israel Rukshin
2019-08-13 16:41 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2019-08-18 9:08 [PATCH 0/5 V5] nvme: Add type of service (TOS) configuration Israel Rukshin
2019-08-18 9:08 ` [PATCH] nvme-cli/fabrics: Add tos param to connect cmd Israel Rukshin
2019-08-15 13:33 [PATCH 0/5 V4] nvme: Add type of service (TOS) configuration Israel Rukshin
2019-08-15 13:33 ` [PATCH] nvme-cli/fabrics: Add tos param to connect cmd Israel Rukshin
2019-08-14 10:19 [PATCH 0/5 V3] nvme: Add type of service (TOS) configuration Israel Rukshin
2019-08-14 10:19 ` [PATCH] nvme-cli/fabrics: Add tos param to connect cmd Israel Rukshin
2019-08-14 17:08 ` Sagi Grimberg
2019-08-15 8:41 ` Max Gurtovoy
2019-08-15 15:18 ` James Smart
2019-08-15 17:13 ` Sagi Grimberg
2019-08-04 9:55 [PATCH 1/2] nvme-fabrics: Add type of service (TOS) configuration Israel Rukshin
2019-08-04 9:55 ` [PATCH] nvme-cli/fabrics: Add tos param to connect cmd Israel Rukshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fa103b-bac4-f0d7-5b43-8a8fff8227b5@mellanox.com \
--to=israelr@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).