From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <maxg@mellanox.com>,
linux-nvme@lists.infradead.org, hch@lst.de, loberman@redhat.com,
bvanassche@acm.org, linux-rdma@vger.kernel.org
Cc: rgirase@redhat.com, vladimirk@mellanox.com, leonro@mellanox.com,
shlomin@mellanox.com, dledford@redhat.com, jgg@mellanox.com,
oren@mellanox.com, kbusch@kernel.org, idanb@mellanox.com
Subject: Re: [PATCH v2 3/5] nvmet-rdma: use SRQ per completion vector
Date: Thu, 19 Mar 2020 22:47:35 -0700 [thread overview]
Message-ID: <cf52b987-e1d4-0b82-03a2-698ca79bfce0@grimberg.me> (raw)
In-Reply-To: <20200318150257.198402-4-maxg@mellanox.com>
> +static void nvmet_rdma_destroy_srqs(struct nvmet_rdma_device *ndev)
> {
> - if (!ndev->srq)
> + int i;
> +
> + if (!ndev->srqs)
> return;
>
> - nvmet_rdma_free_cmds(ndev, ndev->srq_cmds, ndev->srq_size, false);
> - ib_destroy_srq(ndev->srq);
> + for (i = 0; i < ndev->srq_count; i++)
> + nvmet_rdma_destroy_srq(ndev->srqs[i]);
> +
> + rdma_srq_pool_destroy(ndev->pd);
> + kfree(ndev->srqs);
> + ndev->srqs = NULL;
> + ndev->srq_count = 0;
> + ndev->srq_size = 0;
What is the point assigning these?
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-20 5:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:02 [PATCH v2 0/5] nvmet-rdma/srpt: SRQ per completion vector Max Gurtovoy
2020-03-18 15:02 ` [PATCH v2 1/5] IB/core: add a simple SRQ pool per PD Max Gurtovoy
2020-03-20 5:59 ` Sagi Grimberg
2020-03-20 13:21 ` Max Gurtovoy
2020-03-20 14:27 ` Leon Romanovsky
2020-03-18 15:02 ` [PATCH v2 2/5] nvmet-rdma: add srq pointer to rdma_cmd Max Gurtovoy
2020-03-18 23:32 ` Jason Gunthorpe
2020-03-19 8:48 ` Max Gurtovoy
2020-03-19 9:14 ` Leon Romanovsky
2020-03-19 10:55 ` Max Gurtovoy
2020-03-19 11:54 ` Jason Gunthorpe
2020-03-19 14:08 ` Konstantin Ryabitsev
2020-03-19 21:58 ` Konstantin Ryabitsev
2020-03-19 4:05 ` Bart Van Assche
2020-03-18 15:02 ` [PATCH v2 3/5] nvmet-rdma: use SRQ per completion vector Max Gurtovoy
2020-03-19 4:09 ` Bart Van Assche
2020-03-19 9:15 ` Max Gurtovoy
2020-03-19 11:56 ` Jason Gunthorpe
2020-03-19 12:48 ` Max Gurtovoy
2020-03-19 13:53 ` Jason Gunthorpe
2020-03-19 14:49 ` Bart Van Assche
[not found] ` <50dd8f5d-d092-54bc-236d-1e702fb95240@mellanox.com>
[not found] ` <6e3cc1c4-b24e-f607-42b3-5b83dd8c312c@mellanox.com>
2020-03-19 16:27 ` Max Gurtovoy
2020-03-20 5:47 ` Sagi Grimberg [this message]
2020-03-18 15:02 ` [PATCH v2 4/5] RDMA/srpt: use ib_alloc_cq instead of ib_alloc_cq_any Max Gurtovoy
2020-03-19 4:15 ` Bart Van Assche
2020-03-18 15:02 ` [PATCH v2 5/5] RDMA/srpt: use SRQ per completion vector Max Gurtovoy
2020-03-19 4:20 ` Bart Van Assche
2020-03-19 4:02 ` [PATCH v2 0/5] nvmet-rdma/srpt: " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf52b987-e1d4-0b82-03a2-698ca79bfce0@grimberg.me \
--to=sagi@grimberg.me \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=idanb@mellanox.com \
--cc=jgg@mellanox.com \
--cc=kbusch@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=maxg@mellanox.com \
--cc=oren@mellanox.com \
--cc=rgirase@redhat.com \
--cc=shlomin@mellanox.com \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).