From: David Milburn <dmilburn@redhat.com>
To: Yi Zhang <yi.zhang@redhat.com>, kbusch@kernel.org, hch@lst.de
Cc: sujith_pandel@dell.com, emilne@redhat.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info
Date: Fri, 14 Feb 2020 07:53:57 -0600 [thread overview]
Message-ID: <d72e9d2f-6857-305f-54bb-2fb25448dc37@redhat.com> (raw)
In-Reply-To: <20200214104802.29209-1-yi.zhang@redhat.com>
Hi,
On 02/14/2020 04:48 AM, Yi Zhang wrote:
> nvme fw-activate operation will get bellow warning log,
> fix it by update the parameter order
>
> [ 113.231513] nvme nvme0: Get FW SLOT INFO log error
>
> Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages")
> Reported-by: Sujith Pandel <sujith_pandel@dell.com>
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 5dc32b72e7fa..641c07347e8d 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3867,7 +3867,7 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl)
> if (!log)
> return;
>
> - if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log,
> + if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log,
> sizeof(*log), 0))
> dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
> kfree(log);
>
The controller returns a status of "Invalid Log Page" from
nvme_get_log() on different devices.
Reviewed-by: David Milburn <dmilburn@redhat.com>
Thanks,
David
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-14 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 10:48 [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info Yi Zhang
2020-02-14 13:53 ` David Milburn [this message]
2020-02-14 14:26 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d72e9d2f-6857-305f-54bb-2fb25448dc37@redhat.com \
--to=dmilburn@redhat.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sujith_pandel@dell.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).