From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv2] nvme: send uevent once a multipath namespace is operational again
Date: Wed, 3 Mar 2021 14:05:19 +0100 [thread overview]
Message-ID: <eb11c7b3-edc9-b492-12d9-7ff279c3bf97@suse.de> (raw)
In-Reply-To: <20210303123239.GA28477@lst.de>
On 3/3/21 1:32 PM, Christoph Hellwig wrote:
> On Wed, Mar 03, 2021 at 01:12:27PM +0100, Hannes Reinecke wrote:
>> In an all paths down scenario I/O will be requeued or aborted, and no
>> further I/O will be ongoing on this namespace.
>> This leaves the upper layers unable to determine if the namespace
>> becomes operational again eg. after a successful controller reset.
>> With this patch a 'change' uevent will be sent per multipathed namespace
>> once the underlying controller moved to LIVE and started I/O processing
>> by calling nvme_kick_requeue_lists().
>
> This looks functionally correct, but I'm a little worried about the
> nvme_kick_requeue_lists function name being a little off now. Can
> anyone on the list think of a better name?
>
nvme_restart_processing()?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-03 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 12:12 [PATCHv2] nvme: send uevent once a multipath namespace is operational again Hannes Reinecke
2021-03-03 12:32 ` Christoph Hellwig
2021-03-03 13:05 ` Hannes Reinecke [this message]
2021-03-05 21:00 ` Sagi Grimberg
2021-03-11 17:54 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb11c7b3-edc9-b492-12d9-7ff279c3bf97@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).