Re: [PATCH] bus: ti-sysc: Fix quirk flags for lcdc on am335x

From: Dave Gerlach <d-gerlach@ti.com>
To: Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org>
Cc: "Andrew F . Davis" <afd@ti.com>, Faiz Abbas <faiz_abbas@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Roger Quadros <rogerq@ti.com>, Suman Anna <s-anna@ti.com>,
	Tero Kristo <t-kristo@ti.com>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH] bus: ti-sysc: Fix quirk flags for lcdc on am335x
Date: Tue, 10 Mar 2020 10:45:01 -0500	[thread overview]
Message-ID: <1196fb5a-ed41-51bb-67a4-dc9c7fe3ed36@ti.com> (raw)
In-Reply-To: <20200309181912.28645-1-tony@atomide.com>

Tony,
On 3/9/20 1:19 PM, Tony Lindgren wrote:
> Commit adb72394e2ab ("ARM: OMAP2+: Drop legacy platform data for am3
> lcdc") dropped legacy platform data but we never added the quirks for
> SWSUP_SIDLE and SWSUP_MSTANDBY for lcdc for ti-sysc driver.
> 
> This breaks suspend/resume. Let's fix the issue by enabling the same
> quirks for ti-sysc driver as we had earlier with platform data.
> 
> Fixes: adb72394e2ab ("ARM: OMAP2+: Drop legacy platform data for am3 lcdc")
> Fixes: 23731eac9848 ("bus: ti-sysc: Detect devices on am335x when DEBUG is enabled")
> Reported-by: Keerthy <j-keerthy@ti.com>
> Cc: Jyri Sarha <jsarha@ti.com>
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Dave Gerlach <d-gerlach@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> 
> This patch is against v5.6-rc series, it needs a merge conflict resolved
> for Linux next next is using -ENODEV instead of -1 for missing registers.

Tested with v5.6-rc5, can confirm that suspend looks OK now and is 
exited without "pm33xx pm33xx: PM: Could not transition all powerdomains 
to target state" message with this patch.

Tested-by: Dave Gerlach <d-gerlach@ti.com>

Regards,
Dave

> 
> ---
>   drivers/bus/ti-sysc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -1266,6 +1266,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
>   	SYSC_QUIRK("gpu", 0x50000000, 0x14, -1, -1, 0x00010201, 0xffffffff, 0),
>   	SYSC_QUIRK("gpu", 0x50000000, 0xfe00, 0xfe10, -1, 0x40000000 , 0xffffffff,
>   		   SYSC_MODULE_QUIRK_SGX),
> +	SYSC_QUIRK("lcdc", 0, 0, 0x54, -1, 0x4f201000, 0xffffffff,
> +		   SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>   	SYSC_QUIRK("usb_otg_hs", 0, 0x400, 0x404, 0x408, 0x00000050,
>   		   0xffffffff, SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
>   	SYSC_QUIRK("usb_otg_hs", 0, 0, 0x10, -1, 0x4ea2080d, 0xffffffff,
> @@ -1294,7 +1296,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
>   	SYSC_QUIRK("gpu", 0, 0xfe00, 0xfe10, -1, 0x40000000 , 0xffffffff, 0),
>   	SYSC_QUIRK("hsi", 0, 0, 0x10, 0x14, 0x50043101, 0xffffffff, 0),
>   	SYSC_QUIRK("iss", 0, 0, 0x10, -1, 0x40000101, 0xffffffff, 0),
> -	SYSC_QUIRK("lcdc", 0, 0, 0x54, -1, 0x4f201000, 0xffffffff, 0),
>   	SYSC_QUIRK("mcasp", 0, 0, 0x4, -1, 0x44306302, 0xffffffff, 0),
>   	SYSC_QUIRK("mcasp", 0, 0, 0x4, -1, 0x44307b02, 0xffffffff, 0),
>   	SYSC_QUIRK("mcbsp", 0, -1, 0x8c, -1, 0, 0, 0),
> 