From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-watchdog@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, jarkko.nikula@jollamobile.com
Subject: Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core
Date: Mon, 10 Sep 2012 09:45:58 +0300 [thread overview]
Message-ID: <20120910094558.b4e569e67505d3f61bead2d5@bitmer.com> (raw)
In-Reply-To: <1347127441-23125-1-git-send-email-aaro.koskinen@iki.fi>
On Sat, 8 Sep 2012 21:04:01 +0300
Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> Convert omap_wdt to new watchdog core. On OMAP boards, there are usually
> multiple watchdogs. Since the new watchdog core supports multiple
> watchdogs, all watchdog drivers used on OMAP should be converted.
>
> The legacy watchdog device node is still created, so this should not
> break existing users.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
>
> v2: Fix a bug in the first version of the patch: __omap_wdt_disable()
> in probe was mistakenly moved outside PM runtime calls. This caused a
> crash as device was probably accessed with some clocks off. Thanks to
> Jarkko Nikula <jarkko.nikula@bitmer.com> for reporting this.
>
> drivers/watchdog/Kconfig | 1 +
> drivers/watchdog/omap_wdt.c | 266 ++++++++++++++++++-------------------------
> 2 files changed, 114 insertions(+), 153 deletions(-)
>
Tested-by: Jarkko Nikula <jarkko.nikula@jollamobile.com>
next prev parent reply other threads:[~2012-09-10 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 18:04 [PATCH v2] watchdog: omap_wdt: convert to new watchdog core Aaro Koskinen
2012-09-10 6:45 ` Jarkko Nikula [this message]
2012-09-10 9:32 ` Vutla, Lokesh
2012-09-11 9:59 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910094558.b4e569e67505d3f61bead2d5@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=aaro.koskinen@iki.fi \
--cc=jarkko.nikula@jollamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).