Re: [PATCH 1/3] RFC: power: supply: cpcap-battery: Add helper for rough capacity

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

Hi!

> >> Get a rough battery charge estimate until we've seen a high or low
> >> battery level. After that we can use the coulomb counter to calculate
> >> the battery capacity.
> >>
> >> Note that I should probably update this to support ocv-capacity-table
> >> before this makes sense to apply. With ocv-capacity-table we should be
> >> able to estimate battery state as described in the documentation for
> >> Documentation/devicetree/bindings/power/supply/battery.txt.
> > 
> > Maybe we should let userspace do that?
> > 
> > https://github.com/pavelmachek/libbattery
> 
> Unless this gets integrated in UPower, My point of view is that
> userspace probably wants some uniform approach. Kernel interface
> definitely is one uniform interface that would also get picked up by UPower.

I see that it is convenient to have it in kernel. I just assumed
Sebastian would not take that, because it does not _need_ to be in
kernel...

And maybe it is easier in userspace, since userspace has access to
persistent storage, so it can store detailed battery calibration
parameters? (And Gnome/Mate even does something like that, see
mate-power-statistics).

So... not my decision. Don't care too much either way. I have been
doing this in userspace, but...

What I'd like to see is some kind of indication that "this attribute
is not from hardware, kernel computed it for you" so clever userspace
can ignore it/compute it in more advanced way.

Best regards,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]