From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7B6C35E01 for ; Tue, 25 Feb 2020 14:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D673020732 for ; Tue, 25 Feb 2020 14:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lxX6Rz7n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730681AbgBYORD (ORCPT ); Tue, 25 Feb 2020 09:17:03 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:59584 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730629AbgBYORD (ORCPT ); Tue, 25 Feb 2020 09:17:03 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98BDB43F; Tue, 25 Feb 2020 15:17:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582640221; bh=sZZG678FJ2JreTGUkYa0F2UpGMGiy+FTyQpon9jVA/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lxX6Rz7nqlSz2r44ey7qjfRZ6Wx4F18qKUoW/gTYW4MEX7cjA+3IT0Va9yZZ+7vfk l6FWtMh+VSgti8pTb4/JEGAS2N3q0G7PkMApvtAFW/Tyzr+4l3GJIdgx9xQh/bxK7i 3f6mPWghHEm5o/sLJqVFhR1+f/UvyOkHgmv1cCZw= Date: Tue, 25 Feb 2020 16:16:41 +0200 From: Laurent Pinchart To: Sebastian Reichel Cc: Sebastian Reichel , Tomi Valkeinen , Tony Lindgren , Merlijn Wajer , "H. Nikolaus Schaller" , Rob Herring , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCHv2 07/56] drm/omap: dsi: add generic transfer function Message-ID: <20200225141641.GF4764@pendragon.ideasonboard.com> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200224232126.3385250-8-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200224232126.3385250-8-sebastian.reichel@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Sebastian, Thank you for the patch. On Tue, Feb 25, 2020 at 12:20:37AM +0100, Sebastian Reichel wrote: > This prepares the driver for becoming a mipi_dsi_host implementation, > which provides a generic transfer function instead of all kind of > different read/write functions. The implementation will become more > elegant after unexporting the specific functions in the following > patches. > > Signed-off-by: Sebastian Reichel > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 52 +++++++++++++++++++++++++++ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++ > 2 files changed, 55 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index f01e0476296d..84e2eb0b51d7 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4836,6 +4836,56 @@ static void dsi_release_vc(struct omap_dss_device *dssdev, int channel) > } > } > > +static ssize_t omap_dsi_transfer(struct omap_dss_device *dssdev, > + const struct mipi_dsi_msg *msg) > +{ > + /* > + * no_sync can be used to optimize performance by sending > + * e.g. column and page information without syncing in > + * between. It's not absolutley required, so postpone this > + * feature for now. The 80 columns limit is quite small as it is, no need to make it even tighter :-) > + */ > + bool no_sync = false; > + u16 val; > + > + switch (msg->type) { > + case MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM: > + case MIPI_DSI_GENERIC_SHORT_WRITE_1_PARAM: > + case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM: > + case MIPI_DSI_GENERIC_LONG_WRITE: > + if (no_sync) > + return dsi_vc_generic_write_nosync(dssdev, msg->channel, > + msg->tx_buf, msg->tx_len); This uses spaces for indentation (and the result isn't aligned to (). > + else > + return dsi_vc_generic_write(dssdev, msg->channel, > + msg->tx_buf, msg->tx_len); > + case MIPI_DSI_DCS_SHORT_WRITE: > + case MIPI_DSI_DCS_SHORT_WRITE_PARAM: > + case MIPI_DSI_DCS_LONG_WRITE: > + if (no_sync) > + return dsi_vc_dcs_write_nosync(dssdev, msg->channel, > + msg->tx_buf, msg->tx_len); Misaligned indentation here too. > + else > + return dsi_vc_dcs_write(dssdev, msg->channel, > + msg->tx_buf, msg->tx_len); > + case MIPI_DSI_GENERIC_READ_REQUEST_0_PARAM: > + case MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM: > + case MIPI_DSI_GENERIC_READ_REQUEST_2_PARAM: > + return dsi_vc_generic_read(dssdev, msg->channel, msg->tx_buf, > + msg->tx_len, msg->rx_buf, msg->rx_len); And here. > + case MIPI_DSI_DCS_READ: > + return dsi_vc_dcs_read(dssdev, msg->channel, > + ((u8*) msg->tx_buf)[0], > + msg->rx_buf, msg->rx_len); And I think you get the message :-) > + case MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE: > + val = le16_to_cpu(*((__le16*) msg->tx_buf)); > + return dsi_vc_set_max_rx_packet_size(dssdev, msg->channel, val); > + case MIPI_DSI_NULL_PACKET: > + return dsi_vc_send_null(to_dsi_data(dssdev), msg->channel); > + } > + > + return -EINVAL; > +} > > static int dsi_get_clocks(struct dsi_data *dsi) > { > @@ -4890,6 +4940,8 @@ static const struct omap_dss_device_ops dsi_ops = { > .set_vc_id = dsi_set_vc_id, > .release_vc = dsi_release_vc, > > + .transfer = omap_dsi_transfer, > + > .dcs_write = dsi_vc_dcs_write, > .dcs_write_nosync = dsi_vc_dcs_write_nosync, > .dcs_read = dsi_vc_dcs_read, > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index b909b3a8c835..ea7bf0970677 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -307,6 +307,9 @@ struct omapdss_dsi_ops { > void (*release_vc)(struct omap_dss_device *dssdev, int channel); > > /* data transfer */ > + ssize_t (*transfer)(struct omap_dss_device *dssdev, > + const struct mipi_dsi_msg *msg); Ditto. With those small issues fixed, Reviewed-by: Laurent Pinchart > + > int (*dcs_write)(struct omap_dss_device *dssdev, int channel, > const u8 *data, int len); > int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel, -- Regards, Laurent Pinchart