From: Pavel Machek <pavel@denx.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>, Rob Herring <robh@kernel.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Lee Jones <lee.jones@linaro.org>, Jiri Slaby <jslaby@suse.cz>,
Merlijn Wajer <merlijn@wizzup.org>,
Peter Hurley <peter@hurleysoftware.com>,
Sebastian Reichel <sre@kernel.org>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/6] serdev: ngsm: Add generic serdev-ngsm driver
Date: Fri, 1 May 2020 22:44:26 +0200 [thread overview]
Message-ID: <20200501204426.GE6043@duo.ucw.cz> (raw)
In-Reply-To: <20200430174615.41185-4-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
Hi!
> We can have a generic serdev-ngsm driver bring up the TS 27.010 line
> discipline on the selected serial ports based on device tree data.
>
> And we can now do standard Linux device driver for the dedicated
> TS 27.010 channels for devices like GNSS and ALSA found on modems.
> +++ b/drivers/tty/serdev/Kconfig
> @@ -22,4 +22,14 @@ config SERIAL_DEV_CTRL_TTYPORT
> depends on SERIAL_DEV_BUS != m
> default y
>
> +config SERIAL_DEV_N_GSM
> + tristate "Serial device TS 27.010 support"
> + help
> + Select this if you want to use the TS 27.010 with a serial port with
> + devices such as modems and GNSS devices.
> +
> + If unsure, say N.
> + depends on N_GSM
> + depends on SERIAL_DEV_CTRL_TTYPORT
Normally, depends go after "tristate" and before "help" text. I did
not realize this is valid code.
Reviewed-by: Pavel Machek <pavel@ucw.cz>
> +/*
> + * Configure SoC 8250 device for 700 ms autosuspend delay, Values around 600 ms
> + * and shorter cause spurious wake-up events at least on droid 4. Also keep the
droid->Droid?
> +static const struct serdev_ngsm_cfg motmdm_cfg = {
> + .gsm = &adaption1,
> + .init_retry_quirk = true,
> + .needs_usb_phy = true,
> + .aggressive_pm = true,
Umm. These are unsigned int:1, not bools, so = 1 would be expected
here.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-05-01 20:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 17:46 [PATCHv6 0/6] n_gsm serdev support and GNSS driver for droid4 Tony Lindgren
2020-04-30 17:46 ` [PATCH 1/6] tty: n_gsm: Add support for serdev drivers Tony Lindgren
2020-05-01 20:31 ` Pavel Machek
2020-05-01 21:31 ` Tony Lindgren
2020-04-30 17:46 ` [PATCH 2/6] dt-bindings: serdev: ngsm: Add binding for serdev-ngsm Tony Lindgren
2020-05-01 20:33 ` Pavel Machek
2020-05-12 15:37 ` Rob Herring
2020-04-30 17:46 ` [PATCH 3/6] serdev: ngsm: Add generic serdev-ngsm driver Tony Lindgren
2020-05-01 20:44 ` Pavel Machek [this message]
2020-04-30 17:46 ` [PATCH 4/6] dt-bindings: gnss: Add binding for Motorola Mapphone MDM6600 GNSS Tony Lindgren
2020-05-01 20:45 ` Pavel Machek
2020-05-01 21:14 ` Rob Herring
2020-05-01 21:19 ` Rob Herring
2020-05-01 21:25 ` Tony Lindgren
2020-04-30 17:46 ` [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Tony Lindgren
2020-05-01 20:51 ` Pavel Machek
2020-04-30 17:46 ` [PATCH 6/6] ARM: dts: omap4-droid4: Configure modem for serdev-ngsm Tony Lindgren
2020-05-01 20:53 ` Pavel Machek
2020-04-30 22:26 ` [PATCHv6 0/6] n_gsm serdev support and GNSS driver for droid4 Pavel Machek
2020-05-01 14:52 ` Tony Lindgren
2020-05-01 22:06 ` Pavel Machek
2020-05-01 8:21 ` Pavel Machek
2020-05-01 14:20 ` Tony Lindgren
2020-05-01 20:19 ` Pavel Machek
2020-05-01 20:32 ` Tony Lindgren
2020-05-01 20:23 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501204426.GE6043@duo.ucw.cz \
--to=pavel@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.cz \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=peter@hurleysoftware.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).