Hi Adam, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on omap/for-next] [also build test WARNING on balbi-usb/testing/next linus/master v5.9-rc1 next-20200818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Adam-Ford/thermal-ti-soc-thermal-Enable-addition-power-management/20200819-000006 base: https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next config: riscv-randconfig-r033-20200818 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/thermal/ti-soc-thermal/ti-bandgap.c:38:12: warning: function 'bandgap_omap_cpu_notifier' has internal linkage but is not defined [-Wundefined-internal] static int bandgap_omap_cpu_notifier(struct notifier_block *nb, ^ drivers/thermal/ti-soc-thermal/ti-bandgap.c:1019:26: note: used here bgp->nb.notifier_call = bandgap_omap_cpu_notifier; ^ 1 warning generated. # https://github.com/0day-ci/linux/commit/ad9a82ecd12253bef4dfda9192916ae04b09ea6e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Adam-Ford/thermal-ti-soc-thermal-Enable-addition-power-management/20200819-000006 git checkout ad9a82ecd12253bef4dfda9192916ae04b09ea6e vim +/bandgap_omap_cpu_notifier +38 drivers/thermal/ti-soc-thermal/ti-bandgap.c 36 37 static int ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id); > 38 static int bandgap_omap_cpu_notifier(struct notifier_block *nb, 39 unsigned long cmd, void *v); 40 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org