From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF1FC63777 for ; Tue, 1 Dec 2020 00:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B424207F7 for ; Tue, 1 Dec 2020 00:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="foUlpfLt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389190AbgLAAe1 (ORCPT ); Mon, 30 Nov 2020 19:34:27 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:35712 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389113AbgLAAe1 (ORCPT ); Mon, 30 Nov 2020 19:34:27 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C16F31D; Tue, 1 Dec 2020 01:33:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1606782826; bh=PNlJMlKMDZLvPTxNTkvuBa+89L37a2Wh9uDw7vvIt6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=foUlpfLtrX/JXdO+L/1pfH7wufKqIuiv/0TvNQsZWqSkLOpRgm9TFWLLxiLsjElJm L1IJ8TNJNH6nUAQXd1ymLHo9sel4NrmFDCzryFGTwNtaAAawHlwf+PLznXyl1QcxmC QM0VuHOwdaYaEaE22iQQ40iiTKRYKnpWSZEzyiC0= Date: Tue, 1 Dec 2020 02:33:36 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com Subject: Re: [PATCH v4 74/80] drm/omap: dsi: display_disable cleanup Message-ID: <20201201003336.GS25713@pendragon.ideasonboard.com> References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-75-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201124124538.660710-75-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:32PM +0200, Tomi Valkeinen wrote: > We can drop dsi_display_disable() which just calls > _dsi_display_disable(), and rename _dsi_display_disable() to > dsi_display_disable(). Same comment as for the previous patch. I'd actually squash the two. Reviewed-by: Laurent Pinchart > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index e50418db71ef..d23fc43f1d1e 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -63,8 +63,6 @@ static int dsi_vc_send_null(struct dsi_data *dsi, int vc, int channel); > static ssize_t _omap_dsi_host_transfer(struct dsi_data *dsi, int vc, > const struct mipi_dsi_msg *msg); > > -static void dsi_display_disable(struct omap_dss_device *dssdev); > - > #ifdef DSI_PERF_MEASURE > static bool dsi_perf; > module_param(dsi_perf, bool, 0644); > @@ -3767,7 +3765,7 @@ static void dsi_display_enable(struct dsi_data *dsi) > DSSDBG("dsi_display_ulps_enable FAILED\n"); > } > > -static void _dsi_display_disable(struct dsi_data *dsi, > +static void dsi_display_disable(struct dsi_data *dsi, > bool disconnect_lanes, bool enter_ulps) > { > WARN_ON(!dsi_bus_is_locked(dsi)); > @@ -3786,17 +3784,6 @@ static void _dsi_display_disable(struct dsi_data *dsi, > mutex_unlock(&dsi->lock); > } > > -static void dsi_display_disable(struct omap_dss_device *dssdev) > -{ > - struct dsi_data *dsi = to_dsi_data(dssdev); > - > - WARN_ON(!dsi_bus_is_locked(dsi)); > - > - DSSDBG("dsi_display_disable\n"); > - > - _dsi_display_disable(dsi, true, false); > -} > - > static int dsi_enable_te(struct dsi_data *dsi, bool enable) > { > dsi->te_enabled = enable; > @@ -3820,7 +3807,7 @@ static void omap_dsi_ulps_work_callback(struct work_struct *work) > > dsi_enable_te(dsi, false); > > - _dsi_display_disable(dsi, false, true); > + dsi_display_disable(dsi, false, true); > > dsi_bus_unlock(dsi); > } > @@ -4954,7 +4941,7 @@ static void dsi_bridge_disable(struct drm_bridge *bridge) > > dsi_disable_video_output(dssdev, VC_VIDEO); > > - dsi_display_disable(dssdev); > + dsi_display_disable(dsi, true, false); > > dsi_bus_unlock(dsi); > } -- Regards, Laurent Pinchart