From: Hanna Hawa <hhhawa@amazon.com>
To: <andy.shevchenko@gmail.com>, <tony@atomide.com>,
<haojian.zhuang@linaro.org>, <linus.walleij@linaro.org>
Cc: <dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
<talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
<tgershi@amazon.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <hhhawa@amazon.com>
Subject: [PATCH v4 2/3] pinctrl: pinctrl-single: remove unused parameter
Date: Fri, 19 Mar 2021 17:21:32 +0200 [thread overview]
Message-ID: <20210319152133.28705-3-hhhawa@amazon.com> (raw)
In-Reply-To: <20210319152133.28705-1-hhhawa@amazon.com>
Remove unused parameter 'pin_pos' from pcs_add_pin().
Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
---
drivers/pinctrl/pinctrl-single.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 91c638b85d2c..f3394517cb2e 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -656,10 +656,8 @@ static const struct pinconf_ops pcs_pinconf_ops = {
* pcs_add_pin() - add a pin to the static per controller pin array
* @pcs: pcs driver instance
* @offset: register offset from base
- * @pin_pos: unused
*/
-static int pcs_add_pin(struct pcs_device *pcs, unsigned offset,
- unsigned pin_pos)
+static int pcs_add_pin(struct pcs_device *pcs, unsigned int offset)
{
struct pcs_soc_data *pcs_soc = &pcs->socdata;
struct pinctrl_pin_desc *pin;
@@ -727,16 +725,14 @@ static int pcs_allocate_pin_table(struct pcs_device *pcs)
unsigned offset;
int res;
int byte_num;
- int pin_pos = 0;
if (pcs->bits_per_mux) {
byte_num = (pcs->bits_per_pin * i) / BITS_PER_BYTE;
offset = (byte_num / mux_bytes) * mux_bytes;
- pin_pos = i % num_pins_in_register;
} else {
offset = i * mux_bytes;
}
- res = pcs_add_pin(pcs, offset, pin_pos);
+ res = pcs_add_pin(pcs, offset);
if (res < 0) {
dev_err(pcs->dev, "error adding pins: %i\n", res);
return res;
--
2.17.1
next prev parent reply other threads:[~2021-03-19 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 15:21 [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show() Hanna Hawa
2021-03-19 15:21 ` [PATCH v4 1/3] pinctrl: pinctrl-single: remove unused variable Hanna Hawa
2021-03-24 12:16 ` Tony Lindgren
2021-03-19 15:21 ` Hanna Hawa [this message]
2021-03-24 12:16 ` [PATCH v4 2/3] pinctrl: pinctrl-single: remove unused parameter Tony Lindgren
2021-03-19 15:21 ` [PATCH v4 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero Hanna Hawa
2021-03-24 12:17 ` Tony Lindgren
2021-03-22 5:56 ` [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show() Drew Fustini
2021-03-24 14:03 ` Hawa, Hanna
2021-03-25 8:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319152133.28705-3-hhhawa@amazon.com \
--to=hhhawa@amazon.com \
--cc=andy.shevchenko@gmail.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=haojian.zhuang@linaro.org \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=tgershi@amazon.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).